Introduce a layering in the invalidation component as public and impl

components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java

Index: components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java
diff --git a/components/invalidation/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java b/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java
similarity index 99%
rename from components/invalidation/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java
rename to components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java
index 0b7fec42fb37d9b871c6feec97c84b0b2d7ca199..9f6cc52dceea0951653e31e38efa8c3cb04bed77 100644
--- a/components/invalidation/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java
+++ b/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java
@@ -9,7 +9,6 @@ import android.app.PendingIntent;
 import android.content.ContentResolver;
 import android.content.Intent;
 import android.os.Bundle;
-import android.util.Log;
 
 import com.google.ipc.invalidation.external.client.InvalidationListener.RegistrationState;
 import com.google.ipc.invalidation.external.client.contrib.AndroidListener;
@@ -20,6 +19,7 @@ import com.google.protos.ipc.invalidation.Types.ClientType;
 
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.CollectionUtil;
+import org.chromium.base.Log;

[dcheng, 2015/06/25 18:00:37]

Why make these changes in this patch?

[knn, 2015/06/25 18:20:21]

It is a minor change that saves a presubmit warning.

I did this
//components/invalidation/android/java/src/org/chromium/components/invalidation/PendingInvalidation.java
as well.

I added this to the commit message now, does that address your concern or do you
want me to revert this?

[dcheng, 2015/06/25 18:28:31]

It would be nice to put this in a separate change. It's not too hard with git
(you can squash your commits and then use git add -p to cherry-pick just these
diffs out into another patch).

[knn, 2015/06/25 18:48:51]

Will do.

 import org.chromium.base.VisibleForTesting;
 import org.chromium.sync.AndroidSyncSettings;
 import org.chromium.sync.SyncConstants;
@@ -61,7 +61,7 @@ public class InvalidationClientService extends AndroidListener {
     @VisibleForTesting
     static final int CLIENT_TYPE = ClientType.CHROME_SYNC_ANDROID;
 
-    private static final String TAG = "InvalidationClientService";
+    private static final String TAG = "cr.invalidation";
 
     /**
      * Whether the underlying notification client has been started. This boolean is updated when a