components/invalidation/impl/unacked_invalidation_set.cc - Issue 1191393008: Introduce a layering in the invalidation component as public and impl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/invalidation/impl/unacked_invalidation_set.cc

Issue 1191393008: Introduce a layering in the invalidation component as public and impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/invalidation/impl/DEPS ('K') | « components/invalidation/impl/unacked_invalidation_set.h ('k') | components/invalidation/impl/unacked_invalidation_set_test_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/invalidation/unacked_invalidation_set.h"	5 #include "components/invalidation/impl/unacked_invalidation_set.h"

6	6

7 #include "base/strings/string_number_conversions.h"	7 #include "base/strings/string_number_conversions.h"

8 #include "components/invalidation/ack_handle.h"	8 #include "components/invalidation/public/ack_handle.h"

9 #include "components/invalidation/object_id_invalidation_map.h"	9 #include "components/invalidation/public/object_id_invalidation_map.h"

10	10

11 namespace {	11 namespace {

12	12

13 const char kSourceKey[] = "source";	13 const char kSourceKey[] = "source";

14 const char kNameKey[] = "name";	14 const char kNameKey[] = "name";

15 const char kInvalidationListKey[] = "invalidation-list";	15 const char kInvalidationListKey[] = "invalidation-list";

16	16

17 } // namespace	17 } // namespace

18	18

19 namespace syncer {	19 namespace syncer {

(...skipping 182 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
202 // an UnknownVersion invalidation. We remove the oldest remaining	202 // an UnknownVersion invalidation. We remove the oldest remaining

203 // invalidation to make room for it.	203 // invalidation to make room for it.

204 invalidation::ObjectId id = invalidations_.begin()->object_id();	204 invalidation::ObjectId id = invalidations_.begin()->object_id();

205 invalidations_.erase(*invalidations_.begin());	205 invalidations_.erase(*invalidations_.begin());

206	206

207 Invalidation unknown_version = Invalidation::InitUnknownVersion(id);	207 Invalidation unknown_version = Invalidation::InitUnknownVersion(id);

208 invalidations_.insert(unknown_version);	208 invalidations_.insert(unknown_version);

209 }	209 }

210	210

211 } // namespace syncer	211 } // namespace syncer

OLD	NEW