components/invalidation/DEPS - Issue 1191393008: Introduce a layering in the invalidation component as public and impl

Side by Side Diff: components/invalidation/DEPS

Issue 1191393008: Introduce a layering in the invalidation component as public and impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/invalidation/BUILD.gn ('k') | components/invalidation/ack_handle.h » ('j') | components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "-content",	2 "-components/invalidation",
dcheng 2015/06/25 18:00:37 I think this should still be present. I think this should still be present. knn 2015/06/25 18:20:21 This is a stale value as content is no longer pres Show quoted text On 2015/06/25 18:00:37, dcheng wrote: > I think this should still be present. This is a stale value as content is no longer present by default at the parent folders. dcheng 2015/06/25 18:28:31 I don't understand what you mean. The previous po Show quoted text On 2015/06/25 at 18:20:21, knn wrote: > On 2015/06/25 18:00:37, dcheng wrote: > > I think this should still be present. > > This is a stale value as content is no longer present by default at the parent folders. I don't understand what you mean. The previous policy was the components can't depend on content, and this is what this DEPS line is supposed to enforce. knn 2015/06/25 18:48:51 You can only remove a dep that has been added befo Show quoted text On 2015/06/25 18:28:31, dcheng wrote: > On 2015/06/25 at 18:20:21, knn wrote: > > On 2015/06/25 18:00:37, dcheng wrote: > > > I think this should still be present. > > > > This is a stale value as content is no longer present by default at the parent > folders. > > I don't understand what you mean. > > The previous policy was the components can't depend on content, and this is what > this DEPS line is supposed to enforce. You can only remove a dep that has been added before(inherited from parent folder). content has been removed from the parent folder and this removal is a stale value and must be removed. Same with net/base/mock_host_resolver which is no longer being used here. dcheng 2015/06/25 20:37:25 So this has been broken for awhile? Sorry for the Show quoted text On 2015/06/25 at 18:48:51, knn wrote: > On 2015/06/25 18:28:31, dcheng wrote: > > On 2015/06/25 at 18:20:21, knn wrote: > > > On 2015/06/25 18:00:37, dcheng wrote: > > > > I think this should still be present. > > > > > > This is a stale value as content is no longer present by default at the parent > > folders. > > > > I don't understand what you mean. > > > > The previous policy was the components can't depend on content, and this is what > > this DEPS line is supposed to enforce. > > You can only remove a dep that has been added before(inherited from parent folder). > content has been removed from the parent folder and this removal is a stale value and must be removed. > > Same with net/base/mock_host_resolver which is no longer being used here. So this has been broken for awhile? Sorry for the questions, just trying to understand this.
3

4 "+components/gcm_driver",

5 "+components/keyed_service",

6 "+components/pref_registry",

7 "+components/signin",

8

9 "+google/cacheinvalidation",	3 "+google/cacheinvalidation",

10 "+google_apis/gaia",

11 "+google_apis/gcm",

12 "+jni",

13 "+jingle/notifier",

14 "+net/base/backoff_entry.h",

15 "+net/base/mock_host_resolver.h",

16 "+net/base/network_change_notifier.h",

17 "+net/http/http_status_code.h",

18 "+net/url_request",

19 ]	4 ]

OLD	NEW