Move setOpener from FrameLoader::detach to Frame::detach

Source/web/RemoteFrameClientImpl.cpp

Index: Source/web/RemoteFrameClientImpl.cpp
diff --git a/Source/web/RemoteFrameClientImpl.cpp b/Source/web/RemoteFrameClientImpl.cpp
index a5fb499fd462879bc703ca48544bdd00b97788d0..811c155098567176a1b5f2a0c0774ffa76e4d0b0 100644
--- a/Source/web/RemoteFrameClientImpl.cpp
+++ b/Source/web/RemoteFrameClientImpl.cpp
@@ -55,9 +55,9 @@ Frame* RemoteFrameClientImpl::opener() const
     return toCoreFrame(m_webFrame->opener());
 }
 
-void RemoteFrameClientImpl::setOpener(Frame*)
+void RemoteFrameClientImpl::setOpener(Frame* opener)
 {
-    // FIXME: Implement.
+    m_webFrame->setOpener(WebFrame::fromFrame(opener));

[nasko, 2015/06/23 14:18:51]

Is there a way to avoid duplicating this from FrameLoaderClientImpl? FrameClient
is mostly pure abstract methods and has no impl at all. It isn't the end of the
world, but I'm not happy about it.

[dcheng, 2015/06/23 18:20:43]

It'd be tricky, since you'd have a diamond inheritance problem for
FrameLoaderClientImpl.

The base behavior would need to be in Source/web, since it'd need to talk to
WebFrame. Let's call the base class FrameOwnerImplBase. Then you'd need to have
FrameLoaderClientImpl inherit FrameOwnerImplBase and FrameLoaderClient... but
both are subclasses of FrameClient.

 }
 
 Frame* RemoteFrameClientImpl::parent() const