Move setOpener from FrameLoader::detach to Frame::detach

Source/web/RemoteFrameClientImpl.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "web/RemoteFrameClientImpl.h"
 
 #include "core/events/KeyboardEvent.h"
 #include "core/events/MouseEvent.h"
 #include "core/events/WheelEvent.h"
@@ skipping 37 matching lines @@
     // Clear our reference to RemoteFrame at the very end, in case the client
     // refers to it.
     m_webFrame->setCoreFrame(nullptr);
 }
 
 Frame* RemoteFrameClientImpl::opener() const
 {
     return toCoreFrame(m_webFrame->opener());
 }
 
-void RemoteFrameClientImpl::setOpener(Frame*)
+void RemoteFrameClientImpl::setOpener(Frame* opener)
 {
-    // FIXME: Implement.
+    m_webFrame->setOpener(WebFrame::fromFrame(opener));

[nasko, 2015/06/23 14:18:51]

Is there a way to avoid duplicating this from FrameLoaderClientImpl? FrameClient
is mostly pure abstract methods and has no impl at all. It isn't the end of the
world, but I'm not happy about it.

[dcheng, 2015/06/23 18:20:43]

It'd be tricky, since you'd have a diamond inheritance problem for
FrameLoaderClientImpl.

The base behavior would need to be in Source/web, since it'd need to talk to
WebFrame. Let's call the base class FrameOwnerImplBase. Then you'd need to have
FrameLoaderClientImpl inherit FrameOwnerImplBase and FrameLoaderClient... but
both are subclasses of FrameClient.

 }
 
 Frame* RemoteFrameClientImpl::parent() const
 {
     return toCoreFrame(m_webFrame->parent());
 }
 
 Frame* RemoteFrameClientImpl::top() const
 {
     return toCoreFrame(m_webFrame->top());
@@ skipping 55 matching lines @@
         webEvent = adoptPtr(new WebMouseWheelEventBuilder(m_webFrame->frame()->view(), toCoreFrame(m_webFrame)->ownerLayoutObject(), *static_cast<WheelEvent*>(event)));
 
     // Other or internal Blink events should not be forwarded.
     if (!webEvent || webEvent->type == WebInputEvent::Undefined)
         return;
 
     m_webFrame->client()->forwardInputEvent(webEvent.get());
 }
 
 } // namespace blink