Move setOpener from FrameLoader::detach to Frame::detach

Move setOpener from FrameLoader::detach to Frame::detach

Clearing the opener should happen for all frame detaching, regardless
whether it is a local or remote frame. This CL moves the LocalFrame specific
code (FrameLoader) to the generic one (Frame).

BUG=496923
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197670

[nasko, 2015-06-23 10:46:22]

nasko@chromium.org changed reviewers:
+ dcheng@chromium.org

[nasko, 2015-06-23 10:46:22]

Hey Daniel,
As we discussed, this CL moves setOpener to Frame::detach. The trybots seem
happy. If you think it makes sense, feel free to CQ it.
Thanks in advance!
Nasko

[nasko, 2015-06-23 14:18:52]

https://codereview.chromium.org/1191393007/diff/20001/Source/web/RemoteFrameC...
File Source/web/RemoteFrameClientImpl.cpp (right):

https://codereview.chromium.org/1191393007/diff/20001/Source/web/RemoteFrameC...
Source/web/RemoteFrameClientImpl.cpp:60:
m_webFrame->setOpener(WebFrame::fromFrame(opener));
Is there a way to avoid duplicating this from FrameLoaderClientImpl? FrameClient
is mostly pure abstract methods and has no impl at all. It isn't the end of the
world, but I'm not happy about it.

[dcheng, 2015-06-23 18:20:43]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-06-23 18:20:43]

lgtm

https://codereview.chromium.org/1191393007/diff/20001/Source/web/RemoteFrameC...
File Source/web/RemoteFrameClientImpl.cpp (right):

https://codereview.chromium.org/1191393007/diff/20001/Source/web/RemoteFrameC...
Source/web/RemoteFrameClientImpl.cpp:60:
m_webFrame->setOpener(WebFrame::fromFrame(opener));
On 2015/06/23 at 14:18:51, nasko (paris) wrote:
> Is there a way to avoid duplicating this from FrameLoaderClientImpl?
FrameClient is mostly pure abstract methods and has no impl at all. It isn't the
end of the world, but I'm not happy about it.

It'd be tricky, since you'd have a diamond inheritance problem for
FrameLoaderClientImpl.

The base behavior would need to be in Source/web, since it'd need to talk to
WebFrame. Let's call the base class FrameOwnerImplBase. Then you'd need to have
FrameLoaderClientImpl inherit FrameOwnerImplBase and FrameLoaderClient... but
both are subclasses of FrameClient.

[commit-bot: I haz the power, 2015-06-23 18:21:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191393007/20001

[commit-bot: I haz the power, 2015-06-23 19:35:59]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197670