Issue 1191393004: Make function readNaClRecordTextAndBuildBitcode public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1191393004: Make function readNaClRecordTextAndBuildBitcode public. (Closed)

Created:
5 years, 6 months ago by Karl

Modified:
5 years, 6 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth, Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make function readNaClRecordTextAndBuildBitcode public. Makes readNaClRecordTextAndBuildBitcode public so that it can be used to read bitcode records in textual form for PNaCl subzero. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4169 R=stichnot@chromium.org Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/93d4c9652697eef1dca3ccb6695644c99e7dc4b8

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
	M	include/llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	lib/Bitcode/NaCl/TestUtils/NaClBitcodeTextReader.cpp	View		3 chunks	+5 lines, -11 lines	0 comments	Download

Total messages: 4 (1 generated)

Karl

5 years, 6 months ago (2015-06-22 21:08:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
93d4c9652697eef1dca3ccb6695644c99e7dc4b8 (presubmit successful).