Source/modules/navigatorconnect/ServicePortCollection.idl - Issue 1191393003: Update client side navigator.connect API to use ServicePortCollection [1/3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/navigatorconnect/ServicePortCollection.idl

Issue 1191393003: Update client side navigator.connect API to use ServicePortCollection [1/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@serviceport

Patch Set: address more comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/navigatorconnect/ServicePortCollection.cpp ('k') | Source/modules/navigatorconnect/WorkerNavigatorServices.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/navigatorconnect/ServicePortCollection.idl

diff --git a/Source/modules/navigatorconnect/ServicePortCollection.idl b/Source/modules/navigatorconnect/ServicePortCollection.idl

index 29f0f9d6e4424098ef02b79c36991e9230664c1d..23242adfe4d1279be75018852ffeef19a25b4991 100644

--- a/Source/modules/navigatorconnect/ServicePortCollection.idl

+++ b/Source/modules/navigatorconnect/ServicePortCollection.idl

@@ -5,9 +5,11 @@

// https://mkruisselbrink.github.io/navigator-connect/#idl-def-ServicePortCollection

[

Exposed=(Window,Worker),

+ GarbageCollected,

+ TypeChecking=Interface,

RuntimeEnabled=NavigatorConnect,

] interface ServicePortCollection : EventTarget {

- [CallWith=ScriptState] Promise<ServicePort> connect(DOMString url, optional ServicePortConnectOptions options);

+ [CallWith=ScriptState, RaisesException] Promise<ServicePort> connect(DOMString url, optional ServicePortConnectOptions options);

[CallWith=ScriptState] Promise<ServicePort> match(ServicePortMatchOptions options);

[CallWith=ScriptState] Promise<sequence<ServicePort>> matchAll(optional ServicePortMatchOptions options);

// TODO(mek): The spec has [Exposed=ServiceWorker] for onconnect, this is not currently