chromecast/browser/android/apk/AndroidManifest.xml.jinja2 - Issue 1191373010: Chromecast: fix Android lint warnings, which are now build errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/AndroidManifest.xml.jinja2

Issue 1191373010: Chromecast: fix Android lint warnings, which are now build errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: remove suppressions Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/android/AndroidManifest.xml ('k') | chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastCrashUploader.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/apk/AndroidManifest.xml.jinja2

diff --git a/chromecast/browser/android/apk/AndroidManifest.xml.jinja2 b/chromecast/browser/android/apk/AndroidManifest.xml.jinja2

index 7b02275ffcf035175f6199d467973db47d4d5016..b977a9ddaeb649d59f42ae4068b39f185e1a64aa 100644

--- a/chromecast/browser/android/apk/AndroidManifest.xml.jinja2

+++ b/chromecast/browser/android/apk/AndroidManifest.xml.jinja2

@@ -8,6 +8,13 @@

<manifest xmlns:android="http://schemas.android.com/apk/res/android"

package="org.chromium.chromecast.shell">

+ <uses-sdk android:minSdkVersion="21" android:targetSdkVersion="22" />

+ <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>

+ <uses-permission android:name="android.permission.INTERNET"/>

+ <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>

+ <uses-permission android:name="android.permission.WAKE_LOCK"/>

<application android:name="org.chromium.chromecast.shell.CastApplication"

android:icon="@mipmap/app_icon"

android:label="@string/app_name">

@@ -48,10 +55,4 @@

{% endfor %}

</application>

- <uses-sdk android:minSdkVersion="19" android:targetSdkVersion="19" />

- <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>

- <uses-permission android:name="android.permission.INTERNET"/>

- <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>

- <uses-permission android:name="android.permission.WAKE_LOCK"/>

</manifest>