Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 1191373010: Chromecast: fix Android lint warnings, which are now build errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chromecast/android/AndroidManifest.xml » ('j') | chromecast/chromecast.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 </issue> 95 </issue>
96 <issue id="SetJavaScriptEnabled" severity="ignore"/> 96 <issue id="SetJavaScriptEnabled" severity="ignore"/>
97 <issue id="UnusedResources"> 97 <issue id="UnusedResources">
98 <!-- 98 <!--
99 TODO(pkotwicz): Re-enable after the chrome_java and chrome_staging_java 99 TODO(pkotwicz): Re-enable after the chrome_java and chrome_staging_java
100 targets have been merged. crbug.com/484934 100 targets have been merged. crbug.com/484934
101 --> 101 -->
102 <ignore path="chrome/android/java/res" /> 102 <ignore path="chrome/android/java/res" />
103 <ignore path="content/shell/android/shell_apk/res/layout/content_shell_activ ity.xml" /> 103 <ignore path="content/shell/android/shell_apk/res/layout/content_shell_activ ity.xml" />
104 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" /> 104 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" />
105 <ignore path="chromecast/browser/android/apk/res/values/strings.xml" />
aurimas (slooooooooow) 2015/06/23 00:42:19 Which values and strings are unused?
gunsch 2015/06/23 00:45:43 None now (same thing I pinged you about over chat)
106 <ignore path="chromecast/internal/shell/android/apk/res/values/strings.xml" />
105 </issue> 107 </issue>
106 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 108 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
107 <issue id="UnusedAttribute" severity="ignore"/> 109 <issue id="UnusedAttribute" severity="ignore"/>
108 <issue id="ViewConstructor" severity="ignore"/> 110 <issue id="ViewConstructor" severity="ignore"/>
109 <issue id="WrongCall" severity="ignore"/> 111 <issue id="WrongCall" severity="ignore"/>
110 </lint> 112 </lint>
OLDNEW
« no previous file with comments | « no previous file | chromecast/android/AndroidManifest.xml » ('j') | chromecast/chromecast.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698