chrome/browser/android/omnibox/autocomplete_controller_android.cc - Issue 1191373002: Componentize AutocompleteController and its supporting cast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/omnibox/autocomplete_controller_android.cc

Issue 1191373002: Componentize AutocompleteController and its supporting cast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prep_builtin_provider_for_c14n

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/omnibox/autocomplete_controller_android.h ('k') | chrome/browser/autocomplete/autocomplete_classifier.h » ('j') | chrome/browser/autocomplete/autocomplete_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/omnibox/autocomplete_controller_android.cc

diff --git a/chrome/browser/android/omnibox/autocomplete_controller_android.cc b/chrome/browser/android/omnibox/autocomplete_controller_android.cc

index 4c6423a5d4eda93a52ae18891a8842b0a572f003..9570eb111390846e9b4fbc8f683abbbef36d9633 100644

--- a/chrome/browser/android/omnibox/autocomplete_controller_android.cc

+++ b/chrome/browser/android/omnibox/autocomplete_controller_android.cc

@@ -11,9 +11,7 @@

#include "base/strings/utf_string_conversions.h"

#include "base/time/time.h"

#include "base/timer/timer.h"

-#include "chrome/browser/autocomplete/autocomplete_classifier.h"

#include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"

-#include "chrome/browser/autocomplete/autocomplete_controller.h"

#include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"

#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"

#include "chrome/browser/autocomplete/shortcuts_backend_factory.h"

@@ -34,6 +32,8 @@

#include "components/bookmarks/browser/bookmark_model.h"

#include "components/keyed_service/content/browser_context_dependency_manager.h"

#include "components/metrics/proto/omnibox_event.pb.h"

+#include "components/omnibox/autocomplete_classifier.h"

+#include "components/omnibox/autocomplete_controller.h"

#include "components/omnibox/autocomplete_input.h"

#include "components/omnibox/autocomplete_match.h"

#include "components/omnibox/autocomplete_match_type.h"