components/omnibox/autocomplete_classifier.h - Issue 1191373002: Componentize AutocompleteController and its supporting cast

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/omnibox/autocomplete_classifier.h

Issue 1191373002: Componentize AutocompleteController and its supporting cast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prep_builtin_provider_for_c14n

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/autocomplete/builtin_provider_unittest.cc ('K') | « components/omnibox/DEPS ('k') | components/omnibox/autocomplete_classifier.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CLASSIFIER_H_	5 #ifndef COMPONENTS_OMNIBOX_AUTOCOMPLETE_CLASSIFIER_H_

6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CLASSIFIER_H_	6 #define COMPONENTS_OMNIBOX_AUTOCOMPLETE_CLASSIFIER_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "base/compiler_specific.h"	9 #include "base/compiler_specific.h"

10 #include "base/memory/scoped_ptr.h"	10 #include "base/memory/scoped_ptr.h"

11 #include "base/strings/string16.h"	11 #include "base/strings/string16.h"

12 #include "components/keyed_service/core/keyed_service.h"	12 #include "components/keyed_service/core/keyed_service.h"

13 #include "components/metrics/proto/omnibox_event.pb.h"	13 #include "components/metrics/proto/omnibox_event.pb.h"

14 #include "components/omnibox/autocomplete_scheme_classifier.h"	14 #include "components/omnibox/autocomplete_scheme_classifier.h"

15	15

16 class AutocompleteController;	16 class AutocompleteController;

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 scoped_ptr<AutocompleteController> controller_;	60 scoped_ptr<AutocompleteController> controller_;

61 scoped_ptr<AutocompleteSchemeClassifier> scheme_classifier_;	61 scoped_ptr<AutocompleteSchemeClassifier> scheme_classifier_;

62	62

63 // Are we currently in Classify? Used to verify Classify isn't invoked	63 // Are we currently in Classify? Used to verify Classify isn't invoked

64 // recursively, since this can corrupt state and cause crashes.	64 // recursively, since this can corrupt state and cause crashes.

65 bool inside_classify_;	65 bool inside_classify_;

66	66

67 DISALLOW_IMPLICIT_CONSTRUCTORS(AutocompleteClassifier);	67 DISALLOW_IMPLICIT_CONSTRUCTORS(AutocompleteClassifier);

68 };	68 };

69	69

70 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CLASSIFIER_H_	70 #endif // COMPONENTS_OMNIBOX_AUTOCOMPLETE_CLASSIFIER_H_

OLD	NEW