Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1191333003: MIPS64: Fix 'Revert of Revert of [strong] Implement strong mode restrictions on property access'. (Closed)

Created:
5 years, 6 months ago by balazs.kilvady
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix 'Revert of Revert of [strong] Implement strong mode restrictions on property access'. Port 41405c0470d5b30ec5d22665ed9430c46b33624f TEST=mjsunit/strong/load-property-mutate-backing-store, mjsunit/call-stub BUG= Committed: https://crrev.com/74f97b0d2a4a5102c2817c95139e94ebae900377 Cr-Commit-Position: refs/heads/master@{#29156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/ic/mips64/ic-mips64.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
balazs.kilvady
5 years, 6 months ago (2015-06-19 15:05:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191333003/1
5 years, 6 months ago (2015-06-19 15:08:05 UTC) #4
conradw
Ah, I missed this port. LGTM, although I'm not a committer.
5 years, 6 months ago (2015-06-19 15:12:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-19 15:34:50 UTC) #7
paul.l...
LGTM.
5 years, 6 months ago (2015-06-19 16:07:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191333003/1
5 years, 6 months ago (2015-06-19 16:09:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 16:10:38 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 16:10:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74f97b0d2a4a5102c2817c95139e94ebae900377
Cr-Commit-Position: refs/heads/master@{#29156}

Powered by Google App Engine
This is Rietveld 408576698