Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.h

Issue 119133003: Make InputMethodEngine manage its descriptor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/input_method_engine.h
diff --git a/chrome/browser/chromeos/input_method/input_method_engine.h b/chrome/browser/chromeos/input_method/input_method_engine.h
index 77630953991559468808f866dd5a8c865177fd6e..5c0efb96278619264f751614cc7a4ff6c23489d2 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine.h
+++ b/chrome/browser/chromeos/input_method/input_method_engine.h
@@ -9,6 +9,7 @@
#include <string>
#include <vector>
#include "chrome/browser/chromeos/input_method/input_method_engine_interface.h"
+#include "chromeos/ime/input_method_descriptor.h"
#include "url/gurl.h"
namespace ui {
@@ -42,6 +43,8 @@ class InputMethodEngine : public InputMethodEngineInterface {
const GURL& input_view);
// InputMethodEngineInterface overrides.
+ virtual const input_method::InputMethodDescriptor& GetDescriptor()
+ const OVERRIDE;
virtual void StartIme() OVERRIDE;
virtual bool SetComposition(int context_id,
const char* text,
@@ -96,6 +99,9 @@ class InputMethodEngine : public InputMethodEngineInterface {
void MenuItemToProperty(const MenuItem& item,
input_method::InputMethodProperty* property);
+ // Descriptor of this input method.
+ input_method::InputMethodDescriptor descriptor_;
+
// True if the current context has focus.
bool focused_;
@@ -111,8 +117,8 @@ class InputMethodEngine : public InputMethodEngineInterface {
// This IME ID in Chrome Extension.
std::string engine_id_;
- // This IME ID in ibus.
- std::string ibus_id_;
+ // This IME ID in InputMethodManager.
+ std::string imm_id_;
// Pointer to the object recieving events for this IME.
InputMethodEngineInterface::Observer* observer_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698