Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: content/child/service_worker/service_worker_network_provider.cc

Issue 1191293002: Don't create ServiceWorkerProviderHost for sandboxed frames without allow-same-origin flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/service_worker/service_worker_network_provider.h" 5 #include "content/child/service_worker/service_worker_network_provider.h"
6 6
7 #include "base/atomic_sequence_num.h" 7 #include "base/atomic_sequence_num.h"
8 #include "content/child/child_thread_impl.h" 8 #include "content/child/child_thread_impl.h"
9 #include "content/child/service_worker/service_worker_provider_context.h" 9 #include "content/child/service_worker/service_worker_provider_context.h"
10 #include "content/common/service_worker/service_worker_messages.h" 10 #include "content/common/service_worker/service_worker_messages.h"
(...skipping 20 matching lines...) Expand all
31 31
32 ServiceWorkerNetworkProvider* ServiceWorkerNetworkProvider::FromDocumentState( 32 ServiceWorkerNetworkProvider* ServiceWorkerNetworkProvider::FromDocumentState(
33 base::SupportsUserData* datasource_userdata) { 33 base::SupportsUserData* datasource_userdata) {
34 return static_cast<ServiceWorkerNetworkProvider*>( 34 return static_cast<ServiceWorkerNetworkProvider*>(
35 datasource_userdata->GetUserData(&kUserDataKey)); 35 datasource_userdata->GetUserData(&kUserDataKey));
36 } 36 }
37 37
38 ServiceWorkerNetworkProvider::ServiceWorkerNetworkProvider( 38 ServiceWorkerNetworkProvider::ServiceWorkerNetworkProvider(
39 int route_id, 39 int route_id,
40 ServiceWorkerProviderType provider_type) 40 ServiceWorkerProviderType provider_type)
41 : provider_id_(GetNextProviderId()), 41 : provider_id_(provider_type == SERVICE_WORKER_PROVIDER_FOR_SANDBOXED_FRAME
42 context_(new ServiceWorkerProviderContext(provider_id_)) { 42 ? kInvalidServiceWorkerProviderId
43 : GetNextProviderId()) {
kinuko 2015/06/23 10:55:56 nit: could this part be factored out as a static f
horo 2015/06/23 13:55:13 Done.
44 if (provider_id_ == kInvalidServiceWorkerProviderId)
45 return;
46 context_ = new ServiceWorkerProviderContext(provider_id_);
43 if (!ChildThreadImpl::current()) 47 if (!ChildThreadImpl::current())
44 return; // May be null in some tests. 48 return; // May be null in some tests.
45 ChildThreadImpl::current()->Send(new ServiceWorkerHostMsg_ProviderCreated( 49 ChildThreadImpl::current()->Send(new ServiceWorkerHostMsg_ProviderCreated(
46 provider_id_, route_id, provider_type)); 50 provider_id_, route_id, provider_type));
47 } 51 }
48 52
49 ServiceWorkerNetworkProvider::~ServiceWorkerNetworkProvider() { 53 ServiceWorkerNetworkProvider::~ServiceWorkerNetworkProvider() {
54 if (provider_id_ == kInvalidServiceWorkerProviderId)
55 return;
50 if (!ChildThreadImpl::current()) 56 if (!ChildThreadImpl::current())
51 return; // May be null in some tests. 57 return; // May be null in some tests.
52 ChildThreadImpl::current()->Send( 58 ChildThreadImpl::current()->Send(
53 new ServiceWorkerHostMsg_ProviderDestroyed(provider_id_)); 59 new ServiceWorkerHostMsg_ProviderDestroyed(provider_id_));
54 } 60 }
55 61
56 void ServiceWorkerNetworkProvider::SetServiceWorkerVersionId( 62 void ServiceWorkerNetworkProvider::SetServiceWorkerVersionId(
57 int64 version_id) { 63 int64 version_id) {
64 DCHECK(provider_id_ != kInvalidServiceWorkerProviderId);
kinuko 2015/06/23 10:55:56 nit: DCHECK_NE
horo 2015/06/23 13:55:13 Done.
58 if (!ChildThreadImpl::current()) 65 if (!ChildThreadImpl::current())
59 return; // May be null in some tests. 66 return; // May be null in some tests.
60 ChildThreadImpl::current()->Send( 67 ChildThreadImpl::current()->Send(
61 new ServiceWorkerHostMsg_SetVersionId(provider_id_, version_id)); 68 new ServiceWorkerHostMsg_SetVersionId(provider_id_, version_id));
62 } 69 }
63 70
64 } // namespace content 71 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698