Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: content/child/service_worker/service_worker_network_provider.cc

Issue 1191293002: Don't create ServiceWorkerProviderHost for sandboxed frames without allow-same-origin flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated kinuko's comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/service_worker/service_worker_network_provider.h" 5 #include "content/child/service_worker/service_worker_network_provider.h"
6 6
7 #include "base/atomic_sequence_num.h" 7 #include "base/atomic_sequence_num.h"
8 #include "content/child/child_thread_impl.h" 8 #include "content/child/child_thread_impl.h"
9 #include "content/child/service_worker/service_worker_provider_context.h" 9 #include "content/child/service_worker/service_worker_provider_context.h"
10 #include "content/common/service_worker/service_worker_messages.h" 10 #include "content/common/service_worker/service_worker_messages.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 namespace { 14 namespace {
15 15
16 const char kUserDataKey[] = "SWProviderKey"; 16 const char kUserDataKey[] = "SWProviderKey";
17 17
18 // Must be unique in the child process. 18 // Must be unique in the child process.
19 int GetNextProviderId() { 19 int GetNextProviderId() {
20 static base::StaticAtomicSequenceNumber sequence; 20 static base::StaticAtomicSequenceNumber sequence;
21 return sequence.GetNext(); // We start at zero. 21 return sequence.GetNext(); // We start at zero.
22 } 22 }
23 23
24 // When the provider is for a sandboxed iframe we use
25 // kInvalidServiceWorkerProviderId as the provider type and we don't create
26 // ServiceWorkerProviderContext and ServiceWorkerProviderHost.
27 int GenerateProviderIdForType(const ServiceWorkerProviderType provider_type) {
28 if (provider_type == SERVICE_WORKER_PROVIDER_FOR_SANDBOXED_FRAME)
29 return kInvalidServiceWorkerProviderId;
30 return GetNextProviderId();
31 }
32
24 } // namespace 33 } // namespace
25 34
26 void ServiceWorkerNetworkProvider::AttachToDocumentState( 35 void ServiceWorkerNetworkProvider::AttachToDocumentState(
27 base::SupportsUserData* datasource_userdata, 36 base::SupportsUserData* datasource_userdata,
28 scoped_ptr<ServiceWorkerNetworkProvider> network_provider) { 37 scoped_ptr<ServiceWorkerNetworkProvider> network_provider) {
29 datasource_userdata->SetUserData(&kUserDataKey, network_provider.release()); 38 datasource_userdata->SetUserData(&kUserDataKey, network_provider.release());
30 } 39 }
31 40
32 ServiceWorkerNetworkProvider* ServiceWorkerNetworkProvider::FromDocumentState( 41 ServiceWorkerNetworkProvider* ServiceWorkerNetworkProvider::FromDocumentState(
33 base::SupportsUserData* datasource_userdata) { 42 base::SupportsUserData* datasource_userdata) {
34 return static_cast<ServiceWorkerNetworkProvider*>( 43 return static_cast<ServiceWorkerNetworkProvider*>(
35 datasource_userdata->GetUserData(&kUserDataKey)); 44 datasource_userdata->GetUserData(&kUserDataKey));
36 } 45 }
37 46
38 ServiceWorkerNetworkProvider::ServiceWorkerNetworkProvider( 47 ServiceWorkerNetworkProvider::ServiceWorkerNetworkProvider(
39 int route_id, 48 int route_id,
40 ServiceWorkerProviderType provider_type) 49 ServiceWorkerProviderType provider_type)
41 : provider_id_(GetNextProviderId()), 50 : provider_id_(GenerateProviderIdForType(provider_type)) {
42 context_(new ServiceWorkerProviderContext(provider_id_)) { 51 if (provider_id_ == kInvalidServiceWorkerProviderId)
52 return;
53 context_ = new ServiceWorkerProviderContext(provider_id_);
43 if (!ChildThreadImpl::current()) 54 if (!ChildThreadImpl::current())
44 return; // May be null in some tests. 55 return; // May be null in some tests.
45 ChildThreadImpl::current()->Send(new ServiceWorkerHostMsg_ProviderCreated( 56 ChildThreadImpl::current()->Send(new ServiceWorkerHostMsg_ProviderCreated(
46 provider_id_, route_id, provider_type)); 57 provider_id_, route_id, provider_type));
47 } 58 }
48 59
49 ServiceWorkerNetworkProvider::~ServiceWorkerNetworkProvider() { 60 ServiceWorkerNetworkProvider::~ServiceWorkerNetworkProvider() {
61 if (provider_id_ == kInvalidServiceWorkerProviderId)
62 return;
50 if (!ChildThreadImpl::current()) 63 if (!ChildThreadImpl::current())
51 return; // May be null in some tests. 64 return; // May be null in some tests.
52 ChildThreadImpl::current()->Send( 65 ChildThreadImpl::current()->Send(
53 new ServiceWorkerHostMsg_ProviderDestroyed(provider_id_)); 66 new ServiceWorkerHostMsg_ProviderDestroyed(provider_id_));
54 } 67 }
55 68
56 void ServiceWorkerNetworkProvider::SetServiceWorkerVersionId( 69 void ServiceWorkerNetworkProvider::SetServiceWorkerVersionId(
57 int64 version_id) { 70 int64 version_id) {
71 DCHECK_NE(kInvalidServiceWorkerProviderId, provider_id_);
58 if (!ChildThreadImpl::current()) 72 if (!ChildThreadImpl::current())
59 return; // May be null in some tests. 73 return; // May be null in some tests.
60 ChildThreadImpl::current()->Send( 74 ChildThreadImpl::current()->Send(
61 new ServiceWorkerHostMsg_SetVersionId(provider_id_, version_id)); 75 new ServiceWorkerHostMsg_SetVersionId(provider_id_, version_id));
62 } 76 }
63 77
64 } // namespace content 78 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698