Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1191283003: [date] Use explicit control flow to replace %_ThrowIfNotADate. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[date] Use explicit control flow to replace %_ThrowIfNotADate. R=jarin@chromium.org Committed: https://crrev.com/f2ac85201509f5bf977d065c2b8465e34b69bf5e Cr-Commit-Position: refs/heads/master@{#29211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -121 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +13 lines, -11 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +13 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/macros.py View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-date.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-23 05:40:07 UTC) #1
Benedikt Meurer
Hey Jaro, Remove the macro intrinsic %_ThrowIfNotADate and use simple building blocks instead. Please take ...
5 years, 6 months ago (2015-06-23 05:41:47 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-23 06:41:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191283003/1
5 years, 6 months ago (2015-06-23 06:41:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 06:43:41 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 06:43:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2ac85201509f5bf977d065c2b8465e34b69bf5e
Cr-Commit-Position: refs/heads/master@{#29211}

Powered by Google App Engine
This is Rietveld 408576698