Source/core/editing/VisibleUnits.h - Issue 1191283002: Make VisiblePosition::init to not use being constructed object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleUnits.h

Issue 1191283002: Make VisiblePosition::init to not use being constructed object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-06-22T15:06:30 Change for float-list-changed-before-layout-crash.html Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/VisibleUnits.h

diff --git a/Source/core/editing/VisibleUnits.h b/Source/core/editing/VisibleUnits.h

index 1c7ea12170996d3bdcd4b03cfc622d591fdb5aec..41cf6a062aa5c6f43e95b1d1aefa570e8c82e764 100644

--- a/Source/core/editing/VisibleUnits.h

+++ b/Source/core/editing/VisibleUnits.h

@@ -63,6 +63,7 @@ VisiblePosition endOfLine(const VisiblePosition &);

CORE_EXPORT VisiblePosition previousLinePosition(const VisiblePosition&, LayoutUnit lineDirectionPoint, EditableType = ContentIsEditable);

CORE_EXPORT VisiblePosition nextLinePosition(const VisiblePosition&, LayoutUnit lineDirectionPoint, EditableType = ContentIsEditable);

CORE_EXPORT bool inSameLine(const VisiblePosition &, const VisiblePosition &);

+bool inSameLine(const PositionWithAffinity&, const PositionWithAffinity &);

bool isStartOfLine(const VisiblePosition &);

bool isEndOfLine(const VisiblePosition &);

VisiblePosition logicalStartOfLine(const VisiblePosition &);

« Source/core/editing/PositionWithAffinity.cpp ('K') | « Source/core/editing/VisiblePosition.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »