Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/core/editing/VisiblePosition.h

Issue 1191283002: Make VisiblePosition::init to not use being constructed object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-06-22T16:23:26 Add a comment to PositionWIthAffinity::operator==() Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/PositionWithAffinity.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 return !(a == b); 131 return !(a == b);
132 } 132 }
133 133
134 PassRefPtrWillBeRawPtr<Range> makeRange(const VisiblePosition&, const VisiblePos ition&); 134 PassRefPtrWillBeRawPtr<Range> makeRange(const VisiblePosition&, const VisiblePos ition&);
135 bool setStart(Range*, const VisiblePosition&); 135 bool setStart(Range*, const VisiblePosition&);
136 bool setEnd(Range*, const VisiblePosition&); 136 bool setEnd(Range*, const VisiblePosition&);
137 VisiblePosition startVisiblePosition(const Range*, EAffinity); 137 VisiblePosition startVisiblePosition(const Range*, EAffinity);
138 138
139 Element* enclosingBlockFlowElement(const VisiblePosition&); 139 Element* enclosingBlockFlowElement(const VisiblePosition&);
140 140
141 Position canonicalPositionOf(const Position&);
142 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity &, const Position& anchor);
143
141 bool isFirstVisiblePositionInNode(const VisiblePosition&, const ContainerNode*); 144 bool isFirstVisiblePositionInNode(const VisiblePosition&, const ContainerNode*);
142 bool isLastVisiblePositionInNode(const VisiblePosition&, const ContainerNode*); 145 bool isLastVisiblePositionInNode(const VisiblePosition&, const ContainerNode*);
143 146
144 } // namespace blink 147 } // namespace blink
145 148
146 #ifndef NDEBUG 149 #ifndef NDEBUG
147 // Outside the WebCore namespace for ease of invocation from gdb. 150 // Outside the WebCore namespace for ease of invocation from gdb.
148 void showTree(const blink::VisiblePosition*); 151 void showTree(const blink::VisiblePosition*);
149 void showTree(const blink::VisiblePosition&); 152 void showTree(const blink::VisiblePosition&);
150 #endif 153 #endif
151 154
152 #endif // VisiblePosition_h 155 #endif // VisiblePosition_h
OLDNEW
« no previous file with comments | « Source/core/editing/PositionWithAffinity.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698