chrome/browser/chromeos/login/saml/saml_browsertest.cc - Issue 1191273002: ChromeOS: Show the new POD RE-AUTH ICON when users needs to re-auth

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/saml/saml_browsertest.cc

Issue 1191273002: ChromeOS: Show the new POD RE-AUTH ICON when users needs to re-auth (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update after review. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/lock/screen_locker_tester.cc ('k') | chrome/browser/resources/chromeos/login/oobe_screen.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/saml/saml_browsertest.cc

diff --git a/chrome/browser/chromeos/login/saml/saml_browsertest.cc b/chrome/browser/chromeos/login/saml/saml_browsertest.cc

index 80000f932cf17e67f2375b124d9cbbedb79feedd..f5373b00a2cc431bbdc892cbb8b8cc4b40176a5b 100644

--- a/chrome/browser/chromeos/login/saml/saml_browsertest.cc

+++ b/chrome/browser/chromeos/login/saml/saml_browsertest.cc

@@ -1125,8 +1125,9 @@ IN_PROC_BROWSER_TEST_P(SAMLPolicyTest, PRE_NoSAML) {

IN_PROC_BROWSER_TEST_P(SAMLPolicyTest, NoSAML) {

login_screen_load_observer_->Wait();

// Verify that offline login is allowed.

- JsExpect("window.getComputedStyle(document.querySelector("

- " '#pod-row .signin-button-container')).display == 'none'");

+ JsExpect(

+ "window.getComputedStyle(document.querySelector("

+ " '#pod-row .reauth-hint-container')).display == 'none'");

}

IN_PROC_BROWSER_TEST_P(SAMLPolicyTest, PRE_SAMLNoLimit) {

@@ -1141,8 +1142,9 @@ IN_PROC_BROWSER_TEST_P(SAMLPolicyTest, PRE_SAMLNoLimit) {

IN_PROC_BROWSER_TEST_P(SAMLPolicyTest, SAMLNoLimit) {

login_screen_load_observer_->Wait();

// Verify that offline login is allowed.

- JsExpect("window.getComputedStyle(document.querySelector("

- " '#pod-row .signin-button-container')).display == 'none'");

+ JsExpect(

+ "window.getComputedStyle(document.querySelector("

+ " '#pod-row .reauth-hint-container')).display == 'none'");

}

IN_PROC_BROWSER_TEST_P(SAMLPolicyTest, PRE_SAMLZeroLimit) {

@@ -1157,8 +1159,9 @@ IN_PROC_BROWSER_TEST_P(SAMLPolicyTest, PRE_SAMLZeroLimit) {

IN_PROC_BROWSER_TEST_P(SAMLPolicyTest, SAMLZeroLimit) {

login_screen_load_observer_->Wait();

// Verify that offline login is not allowed.

- JsExpect("window.getComputedStyle(document.querySelector("

- " '#pod-row .signin-button-container')).display != 'none'");

+ JsExpect(

+ "window.getComputedStyle(document.querySelector("

+ " '#pod-row .reauth-hint-container')).display != 'none'");

}

IN_PROC_BROWSER_TEST_P(SAMLPolicyTest, PRE_PRE_TransferCookiesAffiliated) {