Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1191263002: Protect error message formatter against invalid string length. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Protect error message formatter against invalid string length. R=mstarzinger@chromium.org BUG=chromium:500980 LOG=N Committed: https://crrev.com/4b7d5dc4bbebb3444b002c176357f584b17709b7 Cr-Commit-Position: refs/heads/master@{#29135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M src/messages.cc View 2 chunks +12 lines, -1 line 0 comments Download
M src/string-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/string-builder.cc View 3 chunks +8 lines, -12 lines 0 comments Download
A + test/mjsunit/regress/regress-500980.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 6 months ago (2015-06-19 07:48:22 UTC) #1
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-19 08:03:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191263002/1
5 years, 6 months ago (2015-06-19 08:08:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 08:31:28 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 08:31:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b7d5dc4bbebb3444b002c176357f584b17709b7
Cr-Commit-Position: refs/heads/master@{#29135}

Powered by Google App Engine
This is Rietveld 408576698