Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1191253005: Add Observatory mojo_shell hearbeat test (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -12 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/embedder/vmservice/server.dart View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/dart/observatory_test/.gitignore View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/dart/observatory_test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/dart/observatory_test/main.dart View 1 1 chunk +3 lines, -8 lines 0 comments Download
A mojo/dart/observatory_test/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
A mojo/dart/observatory_tester/runner.py View 1 chunk +44 lines, -0 lines 0 comments Download
A mojo/dart/observatory_tester/tester.dart View 1 1 chunk +187 lines, -0 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M sky/engine/core/script/dart_service_isolate/server.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 6 months ago (2015-06-22 19:43:52 UTC) #2
rmacnak
lgtm w/ comments https://codereview.chromium.org/1191253005/diff/1/mojo/dart/embedder/vmservice/server.dart File mojo/dart/embedder/vmservice/server.dart (right): https://codereview.chromium.org/1191253005/diff/1/mojo/dart/embedder/vmservice/server.dart#newcode154 mojo/dart/embedder/vmservice/server.dart:154: var client = new HttpRequestClient(request, _service); ...
5 years, 6 months ago (2015-06-22 20:03:37 UTC) #3
Cutch
https://codereview.chromium.org/1191253005/diff/1/mojo/dart/embedder/vmservice/server.dart File mojo/dart/embedder/vmservice/server.dart (right): https://codereview.chromium.org/1191253005/diff/1/mojo/dart/embedder/vmservice/server.dart#newcode154 mojo/dart/embedder/vmservice/server.dart:154: var client = new HttpRequestClient(request, _service); On 2015/06/22 20:03:37, ...
5 years, 6 months ago (2015-06-22 20:15:24 UTC) #4
Cutch
5 years, 6 months ago (2015-06-22 20:27:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
64cf3447d432010db018f92ff4df533181a23aed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698