Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart

Issue 119123002: Fix a bug in the type inferrer, where a getter call was not seen as a potential closure call. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/inferrer_closure_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart (revision 31225)
+++ sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart (working copy)
@@ -54,6 +54,11 @@
if (called.isForeign(compiler) && called.name == 'JS') {
bailout('Used in JS ${info.call}');
}
+ if (inferrer.types.getInferredTypeOf(called) == currentUser) {
+ // This node can be a closure call as well. For example, `foo()`
+ // where `foo` is a getter.
+ analyzeCall(info);
+ }
}
bool checkIfCurrentUser(element) {
« no previous file with comments | « no previous file | tests/language/inferrer_closure_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698