Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 1191173002: cc: Remove TextureUploader. (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
CC:
chromium-reviews, piman, sunnyps
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove TextureUploader. Drop the TextureUploader and the methods on ResourceProvider for using it. This is no longer used except in a few places that should be using ResourceProvider::CopyToResource instead. Switch those places over. R=enne, vmpstr BUG=413479 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/84b61428f5da71db985a929c57a6dc49cf07b465 Cr-Commit-Position: refs/heads/master@{#335341}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -910 lines) Patch
M cc/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/texture_layer_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M cc/output/delegating_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/resources/prioritized_resource.cc View 1 chunk +0 lines, -2 lines 2 comments Download
M cc/resources/resource_provider.h View 3 chunks +0 lines, -16 lines 0 comments Download
M cc/resources/resource_provider.cc View 9 chunks +0 lines, -118 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D cc/resources/texture_uploader.h View 1 chunk +0 lines, -118 lines 0 comments Download
D cc/resources/texture_uploader.cc View 1 chunk +0 lines, -315 lines 0 comments Download
D cc/resources/texture_uploader_unittest.cc View 1 chunk +0 lines, -255 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
danakj
5 years, 6 months ago (2015-06-19 01:11:44 UTC) #1
danakj
Depends on https://codereview.chromium.org/1194743002/
5 years, 6 months ago (2015-06-19 01:16:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191173002/1
5 years, 6 months ago (2015-06-19 18:27:49 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-19 18:27:54 UTC) #6
vmpstr
https://codereview.chromium.org/1191173002/diff/1/cc/resources/prioritized_resource.cc File cc/resources/prioritized_resource.cc (left): https://codereview.chromium.org/1191173002/diff/1/cc/resources/prioritized_resource.cc#oldcode91 cc/resources/prioritized_resource.cc:91: resource_provider->SetPixels( This doesn't need CopyToResource?
5 years, 6 months ago (2015-06-19 18:33:46 UTC) #7
danakj
https://codereview.chromium.org/1191173002/diff/1/cc/resources/prioritized_resource.cc File cc/resources/prioritized_resource.cc (left): https://codereview.chromium.org/1191173002/diff/1/cc/resources/prioritized_resource.cc#oldcode91 cc/resources/prioritized_resource.cc:91: resource_provider->SetPixels( On 2015/06/19 18:33:46, vmpstr wrote: > This doesn't ...
5 years, 6 months ago (2015-06-19 18:34:41 UTC) #8
vmpstr
lgtm
5 years, 6 months ago (2015-06-19 18:40:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191173002/1
5 years, 6 months ago (2015-06-19 18:41:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 20:54:40 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/84b61428f5da71db985a929c57a6dc49cf07b465 Cr-Commit-Position: refs/heads/master@{#335341}
5 years, 6 months ago (2015-06-19 20:56:42 UTC) #13
brianderson
Now that this is gone, I think we can remove DidAnticipatedDrawTimeChange and the final remaining ...
5 years, 6 months ago (2015-06-19 21:57:33 UTC) #15
danakj
On Fri, Jun 19, 2015 at 2:57 PM, <brianderson@chromium.org> wrote: > Now that this is ...
5 years, 6 months ago (2015-06-19 22:05:04 UTC) #16
mithro-old
5 years, 6 months ago (2015-06-22 12:18:15 UTC) #17
Message was sent while issue was closed.
On 2015/06/19 22:05:04, danakj wrote:
> On Fri, Jun 19, 2015 at 2:57 PM, <mailto:brianderson@chromium.org> wrote:

<snip>

> >
> > Death to SetupPollingMechanisms!
> >
> > https://codereview.chromium.org/1191173002/
> >

\o/

Yay, thanks for doing this!

Powered by Google App Engine
This is Rietveld 408576698