Issue 119113003: Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119113003: Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h} (Closed)

Created:
7 years ago by Andrey Kraynov

Modified:
6 years, 11 months ago

Reviewers:
tkent

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h} This patch copies Source/web/WebFrameImpl.{cpp,h} into Source/web/TextFinder.{cpp,h} for decoupling WebFrameImpl and text finder. Another patch will complete decoupling. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164490

Patch Set 1 #

Patch Set 2 : With copy-detection #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	A +	Source/web/TextFinder.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	A +	Source/web/TextFinder.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

The Patch Set 1 won't be handled as copy. Please specify '--find-copies' to 'git cl ...

7 years ago (2013-12-19 23:41:48 UTC) #1

Andrey Kraynov

On 2013/12/19 23:41:48, tkent (vacation until Jan 5) wrote: > The Patch Set 1 won't ...

7 years ago (2013-12-22 21:34:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iceman@yandex-team.ru/119113003/10001

6 years, 11 months ago (2014-01-06 00:29:29 UTC) #4

jochen (gone - plz use gerrit)

6 years, 11 months ago (2014-01-15 13:13:44 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/139383002/ by jochen@chromium.org.

The reason for reverting is: The follow-up patch was reverted.

I guess it would be easier to do the copy and refactoring in one CL, so we don't
end up with a copy of WebFrameImpl.* that gets stale before the refactoring is
finished..

Expand Messages | Collapse Messages