public/web/WebServiceWorkerContextClient.h - Issue 1191083002: BackgroundSync sync events need to be ExtendableEvents, blink side cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 1191083002: BackgroundSync sync events need to be ExtendableEvents, blink side cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebServiceWorkerContextClient.h

diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h

index 3c20eccf6376a7184c5164d0f213f1de75bc5926..d144efa7f634893d0f79066940f85cc1bf0dff6b 100644

--- a/public/web/WebServiceWorkerContextClient.h

+++ b/public/web/WebServiceWorkerContextClient.h

@@ -134,8 +134,6 @@ public:

// ServiceWorker specific method. Called after SyncEvent (dispatched via

// WebServiceWorkerContextProxy) is handled by the ServiceWorker's script

// context.

- // TODO(chasej): crbug.com/486890 - Remove after cleanup on content side

- virtual void didHandleSyncEventDeprecated(int syncEventID) { }

virtual void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult result) { }

// ServiceWorker specific method. Called after CrossOriginConnectEvent

« no previous file with comments | « no previous file | no next file » | no next file with comments »