Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issue 1191083002: BackgroundSync sync events need to be ExtendableEvents, blink side cleanup (Closed)

Created:
4 years, 10 months ago by chasej
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

BackgroundSync sync events need to be ExtendableEvents, blink side cleanup This is part of a series of patches to correctly fire the Sync event as an ExtendableEvent, instead of a regular Event [1] https://codereview.chromium.org/1162243003/, content side fix [2] https://codereview.chromium.org/1148293011/, blink side fix [3] https://codereview.chromium.org/1160253004/, content browser tests [4] https://codereview.chromium.org/1146063005/, cleanup on content side [5] This patch, blink side cleanup Specific changes in this patch: - Remove obsolete function from public interface for worker context client - Function only existed to prevent compile errors while landing the series of blink and content patches BUG=486890 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M public/web/WebServiceWorkerContextClient.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
chasej
tkent, please take a look.
4 years, 10 months ago (2015-06-18 04:59:06 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-18 04:59:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191083002/1
4 years, 10 months ago (2015-06-18 11:41:48 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 11:45:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197344

Powered by Google App Engine
This is Rietveld 408576698