Issue 1191053002: Fix the sector demo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1191053002: Fix the sector demo. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix the sector demo. Turns out it's ok to not detach all the RenderObjects from the widget tree from each other, since they're not reused... but the WidgetToRenderBoxAdapter's renderBox _is_ reused, so we better detach that one. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f4a626707dde24f61d658e7d4d1148d177437e03

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	sky/sdk/lib/widgets/basic.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-17 22:37:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f4a626707dde24f61d658e7d4d1148d177437e03 (presubmit successful).