Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1191033002: Improve error message in navigator.requestMediaKeySystemAccess() (Closed)

Created:
5 years, 6 months ago by jrummell
Modified:
5 years, 6 months ago
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Improve error message in navigator.requestMediaKeySystemAccess() BUG=480141 TEST=compiles Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
jrummell
This appears to be the only unfriendly EME promise rejection in blink. Not sure how ...
5 years, 6 months ago (2015-06-17 21:40:04 UTC) #2
xhwang
lgtm
5 years, 6 months ago (2015-06-17 21:42:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191033002/1
5 years, 6 months ago (2015-06-17 22:16:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67114)
5 years, 6 months ago (2015-06-18 01:59:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191033002/1
5 years, 6 months ago (2015-06-18 02:05:34 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 03:04:06 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197312

Powered by Google App Engine
This is Rietveld 408576698