Issue 1191013004: Teach the analyzer about dart:sky.internals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1191013004: Teach the analyzer about dart:sky.internals. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Teach the analyzer about dart:sky.internals. This is a short-term fix, the long term fix (see issue 254) involves moving some of these to dart:sky. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a2a2f7db40aedcf9878897f65d701fe83c2baa6f

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	sky/sdk/lib/internals.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	sky/viewer/internals.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-18 20:10:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a2a2f7db40aedcf9878897f65d701fe83c2baa6f (presubmit successful).