[es6] ship Object.assign

[es6] ship Object.assign

BUG=v8:4007
LOG=N
R=rossberg@chromium.org, arv@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/12e194860a56d47a10d89ae34761a4af6b6166bb
Cr-Commit-Position: refs/heads/master@{#29118}

Committed: https://crrev.com/b61e9812c33d596ebb3c6c633f31b2aead67e8ae
Cr-Commit-Position: refs/heads/master@{#29150}

[caitp (gmail), 2015-06-17 17:54:09]

PTAL --- just a flag flipping CL. mike@bocoup tells me that it is green for the
test262 coverage for the feature at https://github.com/tc39/test262/pull/293

[arv (Not doing code reviews), 2015-06-18 04:54:14]

LGTM

Do we want  an intent to ship email?

[rossberg, 2015-06-18 05:18:32]

LGTM

On 2015/06/18 04:54:14, arv wrote:
> Do we want  an intent to ship email?

I don't think that's needed for this, it's a tiny feature.

[caitp (gmail), 2015-06-18 10:59:32]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2015-06-18 10:59:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191003003/1

[commit-bot: I haz the power, 2015-06-18 11:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 11:18:03]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[caitp (gmail), 2015-06-18 13:55:21]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-06-18 13:55:22]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org,
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1191003003/#ps20001
(title: "Fix webkit tests")

[commit-bot: I haz the power, 2015-06-18 13:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191003003/20001

[commit-bot: I haz the power, 2015-06-18 14:56:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-18 14:56:27]

Patchset 2 (id:??) landed as
https://crrev.com/12e194860a56d47a10d89ae34761a4af6b6166bb
Cr-Commit-Position: refs/heads/master@{#29118}

[caitp (gmail), 2015-06-18 18:55:53]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1191593005/ by caitpotter88@gmail.com.

The reason for reverting is: Seems to break asan somehow.

[caitp (gmail), 2015-06-18 19:48:43]

Patchset #3 (id:40001) has been deleted

[caitp (gmail), 2015-06-18 19:50:13]

On 2015/06/18 18:55:53, caitp wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1191593005/ by mailto:caitpotter88@gmail.com.
> 
> The reason for reverting is: Seems to break asan somehow.

I believe the failure was fixed --- for some reason Genesis needed to recurse
slightly more with this patch. I'm not exactly sure why, since the patterns in
harmony-object.js are very similar to the other modules.

Anyone want to take another look?

[caitp (gmail), 2015-06-18 21:08:44]

On 2015/06/18 19:50:13, caitp wrote:
> On 2015/06/18 18:55:53, caitp wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/1191593005/ by
mailto:caitpotter88@gmail.com.
> > 
> > The reason for reverting is: Seems to break asan somehow.
> 
> I believe the failure was fixed --- for some reason Genesis needed to recurse
> slightly more with this patch. I'm not exactly sure why, since the patterns in
> harmony-object.js are very similar to the other modules.
> 
> Anyone want to take another look?

I've tried moving harmony_objects back to staging and moving harmony_arrays into
shipping, and found that this test isn't happy unless the stack limit is upped
to 52, I wonder if this might be a bug somewhere incorrectly reporting an
overflow, or the stack not being cleaned up somewhere

[rossberg, 2015-06-19 13:43:48]

lgtm

[caitp (gmail), 2015-06-19 13:48:38]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-06-19 13:48:38]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1191003003/#ps60001
(title: "Fix asan failure")

[commit-bot: I haz the power, 2015-06-19 13:48:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191003003/60001

[arv (Not doing code reviews), 2015-06-19 13:51:47]

This will sure break a Blink test. Can you add a blink bot the cq?

[arv (Not doing code reviews), 2015-06-19 13:52:14]

On 2015/06/19 at 13:51:47, arv wrote:
> This will sure break a Blink test. Can you add a blink bot the cq?

Never mind me. I see you did already.

[rossberg, 2015-06-19 13:52:51]

On 2015/06/18 21:08:44, caitp wrote:
> I've tried moving harmony_objects back to staging and moving harmony_arrays
into
> shipping, and found that this test isn't happy unless the stack limit is upped
> to 52, I wonder if this might be a bug somewhere incorrectly reporting an
> overflow, or the stack not being cleaned up somewhere

Honestly, I have no idea. If upping the constant works, you should be good.

[commit-bot: I haz the power, 2015-06-19 14:39:11]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-06-19 14:39:23]

Patchset 3 (id:??) landed as
https://crrev.com/b61e9812c33d596ebb3c6c633f31b2aead67e8ae
Cr-Commit-Position: refs/heads/master@{#29150}