Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1190993002: Move Android SkFontMgr::Factory to its own file. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move Android SkFontMgr::Factory to its own file. Committed: https://skia.googlesource.com/skia/+/77f85adadbc3448f4302559c14d8abf8724160da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -36 lines) Patch
M gyp/ports.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
M include/ports/SkFontMgr_android.h View 1 chunk +7 lines, -0 lines 0 comments Download
M include/ports/SkTypeface_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 3 chunks +0 lines, -36 lines 0 comments Download
A src/ports/SkFontMgr_android_factory.cpp View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
Chrome includes SkTypeface_android.h in one place (for testing) so the staging is to also define ...
5 years, 6 months ago (2015-06-17 16:13:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190993002/1
5 years, 6 months ago (2015-06-17 17:47:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 17:53:25 UTC) #6
reed1
lgtm
5 years, 6 months ago (2015-06-17 19:00:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190993002/1
5 years, 6 months ago (2015-06-17 19:06:27 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 19:07:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/77f85adadbc3448f4302559c14d8abf8724160da

Powered by Google App Engine
This is Rietveld 408576698