Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1190933002: Reland Update V8 DEPS. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Update V8 DEPS. Reason for revert: Retry with landmine. Original issue's description: > Revert of Update V8 DEPS. (patchset #1 id:1 of https://codereview.chromium.org/1179703005/) > > Reason for revert: > [Sheriff] gyp change breaks calling gyp on XP: > http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/2849 > > Original issue's description: > > Update V8 DEPS. > > > > Rolling v8/build/gyp to fdcd8bc10c935eff13b391644b01460593c46861 > > > > Rolling v8/tools/clang to 4cc9c6714533a07ba02ca01ed04557f055820532 > > > > TBR=machenbach@chromium.org > > > > Committed: https://crrev.com/6e7e5e833c8bddf7d6a97cd3c01f0afe5a882bd6 > > Cr-Commit-Position: refs/heads/master@{#29059} > > TBR=v8-autoroll@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/ce3b5350826b9453aa1081bba04a7c0efd58db46 > Cr-Commit-Position: refs/heads/master@{#29060}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Landmine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M DEPS View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/get_landmines.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Michael Achenbach
Created Revert of Revert of Update V8 DEPS.
5 years, 6 months ago (2015-06-17 08:57:59 UTC) #1
Michael Achenbach
PTAL
5 years, 6 months ago (2015-06-17 09:07:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190933002/60001
5 years, 6 months ago (2015-06-17 09:07:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 09:08:04 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190933002/60001
5 years, 6 months ago (2015-06-17 09:22:35 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 09:45:55 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-17 11:13:25 UTC) #12
Michael Achenbach
Hmm - maybe I read it wrong the first time. The gyp roll includes actually ...
5 years, 6 months ago (2015-06-17 11:22:12 UTC) #13
Michael Achenbach
5 years, 6 months ago (2015-06-18 11:22:08 UTC) #14
Closing this. Rolling gyp instead with a revert of the offending CL.

Powered by Google App Engine
This is Rietveld 408576698