Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 119093007: Signal handling, take 2. (Closed)

Created:
7 years ago by Anders Johnsen
Modified:
7 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix Windows.\ #

Patch Set 3 : Fix mac. #

Patch Set 4 : Add tests. #

Patch Set 5 : Fix mac some more. #

Patch Set 6 : Clean up Windows #

Total comments: 2

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+825 lines, -54 lines) Patch
M runtime/bin/io_natives.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/process.h View 1 2 3 4 5 6 3 chunks +78 lines, -0 lines 0 comments Download
M runtime/bin/process.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/bin/process_android.cc View 2 chunks +110 lines, -0 lines 0 comments Download
M runtime/bin/process_linux.cc View 2 chunks +110 lines, -0 lines 0 comments Download
M runtime/bin/process_macos.cc View 1 2 3 4 3 chunks +151 lines, -1 line 0 comments Download
M runtime/bin/process_patch.dart View 1 chunk +65 lines, -0 lines 0 comments Download
M runtime/bin/process_win.cc View 1 2 3 4 5 4 chunks +126 lines, -23 lines 0 comments Download
M runtime/bin/signal_blocker.h View 1 chunk +14 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/io_patch.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/io/process.dart View 2 chunks +54 lines, -30 lines 0 comments Download
A tests/standalone/io/signals_test.dart View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
A tests/standalone/io/signals_test_script.dart View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years ago (2013-12-19 15:01:22 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/119093007/diff/100001/runtime/bin/process.h File runtime/bin/process.h (right): https://codereview.chromium.org/119093007/diff/100001/runtime/bin/process.h#newcode44 runtime/bin/process.h:44: enum ProcessSignals { Please add a comment that ...
7 years ago (2013-12-19 15:05:36 UTC) #2
Anders Johnsen
https://codereview.chromium.org/119093007/diff/100001/runtime/bin/process.h File runtime/bin/process.h (right): https://codereview.chromium.org/119093007/diff/100001/runtime/bin/process.h#newcode44 runtime/bin/process.h:44: enum ProcessSignals { On 2013/12/19 15:05:37, Søren Gjesse wrote: ...
7 years ago (2013-12-19 15:07:40 UTC) #3
Anders Johnsen
https://codereview.chromium.org/119093007/diff/100001/runtime/bin/process.h File runtime/bin/process.h (right): https://codereview.chromium.org/119093007/diff/100001/runtime/bin/process.h#newcode44 runtime/bin/process.h:44: enum ProcessSignals { On 2013/12/19 15:05:37, Søren Gjesse wrote: ...
7 years ago (2013-12-19 15:07:41 UTC) #4
Anders Johnsen
7 years ago (2013-12-19 15:08:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #7 manually as r31276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698