Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 119093002: Fix small spec violation in String.prototype.split. (Closed)

Created:
7 years ago by Yang
Modified:
7 years ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix small spec violation in String.prototype.split. Also slightly extended the test coverage. R=rossberg@chromium.org BUG=v8:3026 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=18405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M src/string.js View 1 chunk +7 lines, -9 lines 0 comments Download
A + test/mjsunit/regress/regress-3026.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/string-split.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years ago (2013-12-19 10:08:56 UTC) #1
rossberg
lgtm
7 years ago (2013-12-19 10:30:49 UTC) #2
Yang
7 years ago (2013-12-23 10:01:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698