Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 119083003: When issueing a request after preconnect, use the correct referrer policy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 938 matching lines...) Expand 10 before | Expand all | Expand 10 after
949 949
950 void RenderFrameImpl::didUpdateCurrentHistoryItem(blink::WebFrame* frame) { 950 void RenderFrameImpl::didUpdateCurrentHistoryItem(blink::WebFrame* frame) {
951 // TODO(nasko): Move implementation here. Needed methods: 951 // TODO(nasko): Move implementation here. Needed methods:
952 // * StartNavStateSyncTimerIfNecessary 952 // * StartNavStateSyncTimerIfNecessary
953 render_view_->didUpdateCurrentHistoryItem(frame); 953 render_view_->didUpdateCurrentHistoryItem(frame);
954 } 954 }
955 955
956 void RenderFrameImpl::willRequestAfterPreconnect( 956 void RenderFrameImpl::willRequestAfterPreconnect(
957 blink::WebFrame* frame, 957 blink::WebFrame* frame,
958 blink::WebURLRequest& request) { 958 blink::WebURLRequest& request) {
959 blink::WebReferrerPolicy referrer_policy = blink::WebReferrerPolicyDefault; 959 blink::WebReferrerPolicy referrer_policy = frame->document().referrerPolicy();
960 // FIXME(kohei): This will never be set.
960 WebString custom_user_agent; 961 WebString custom_user_agent;
961 962
962 if (request.extraData()) { 963 DCHECK(!request.extraData());
963 // This will only be called before willSendRequest, so only ExtraData
964 // members we have to copy here is on WebURLRequestExtraDataImpl.
965 webkit_glue::WebURLRequestExtraDataImpl* old_extra_data =
966 static_cast<webkit_glue::WebURLRequestExtraDataImpl*>(
967 request.extraData());
968
969 referrer_policy = old_extra_data->referrer_policy();
970 custom_user_agent = old_extra_data->custom_user_agent();
971 }
972 964
973 bool was_after_preconnect_request = true; 965 bool was_after_preconnect_request = true;
974 // The args after |was_after_preconnect_request| are not used, and set to 966 // The args after |was_after_preconnect_request| are not used, and set to
975 // correct values at |willSendRequest|. 967 // correct values at |willSendRequest|.
976 request.setExtraData(new webkit_glue::WebURLRequestExtraDataImpl( 968 request.setExtraData(new webkit_glue::WebURLRequestExtraDataImpl(
977 referrer_policy, custom_user_agent, was_after_preconnect_request)); 969 referrer_policy, custom_user_agent, was_after_preconnect_request));
978 } 970 }
979 971
980 void RenderFrameImpl::willSendRequest( 972 void RenderFrameImpl::willSendRequest(
981 blink::WebFrame* frame, 973 blink::WebFrame* frame,
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
1375 void RenderFrameImpl::AddObserver(RenderFrameObserver* observer) { 1367 void RenderFrameImpl::AddObserver(RenderFrameObserver* observer) {
1376 observers_.AddObserver(observer); 1368 observers_.AddObserver(observer);
1377 } 1369 }
1378 1370
1379 void RenderFrameImpl::RemoveObserver(RenderFrameObserver* observer) { 1371 void RenderFrameImpl::RemoveObserver(RenderFrameObserver* observer) {
1380 observer->RenderFrameGone(); 1372 observer->RenderFrameGone();
1381 observers_.RemoveObserver(observer); 1373 observers_.RemoveObserver(observer);
1382 } 1374 }
1383 1375
1384 } // namespace content 1376 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698