Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1190823003: Remove dependency on headers stream from QuicSession. (Closed)

Created:
5 years, 6 months ago by ramant (doing other things)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0616
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on headers stream from QuicSession. Previously QuicSession was always creating headers stream with stream_id=3. That stream is useless for P2P QUIC connections. Added new QuicSpdySession class and moved all headers-related logic from QuicSession to QuicSpdySession. relnote: QUIC refactoring, doesn't affect functionality Merge internal change: 95762401 R=rch@chromium.org, sergeyu@chromium.org Committed: https://crrev.com/b865eb88a8e8834ca0f5c6e9e55288bf43e5d92b Cr-Commit-Position: refs/heads/master@{#334903}

Patch Set 1 #

Patch Set 2 : deleted an include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+590 lines, -458 lines) Patch
M net/net.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_client_session.cc View 8 chunks +13 lines, -15 lines 0 comments Download
M net/quic/quic_client_session_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_client_session_base.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection_logger.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection_logger_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_data_stream.h View 3 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_data_stream.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_headers_stream.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_headers_stream.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_reliable_client_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.h View 8 chunks +27 lines, -50 lines 0 comments Download
M net/quic/quic_session.cc View 20 chunks +61 lines, -115 lines 0 comments Download
M net/quic/quic_session_test.cc View 28 chunks +57 lines, -60 lines 0 comments Download
A net/quic/quic_spdy_session.h View 1 chunk +76 lines, -0 lines 0 comments Download
A net/quic/quic_spdy_session.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 2 chunks +3 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 2 chunks +3 lines, -14 lines 0 comments Download
A net/quic/test_tools/quic_spdy_session_peer.h View 1 chunk +32 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_spdy_session_peer.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 6 chunks +27 lines, -27 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 6 chunks +20 lines, -18 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_session.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 5 chunks +12 lines, -13 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 3 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 7 chunks +22 lines, -18 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ramant (doing other things)
5 years, 6 months ago (2015-06-17 00:46:43 UTC) #1
ramant (doing other things)
Hi Ryan, This CL required little bit of porting (or changes) to chromium specific classes. ...
5 years, 6 months ago (2015-06-17 00:58:43 UTC) #2
Ryan Hamilton
On 2015/06/17 00:58:43, ramant wrote: > Hi Ryan, > This CL required little bit of ...
5 years, 6 months ago (2015-06-17 13:49:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190823003/20001
5 years, 6 months ago (2015-06-17 16:58:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/34876)
5 years, 6 months ago (2015-06-17 18:41:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190823003/20001
5 years, 6 months ago (2015-06-17 19:24:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-17 20:21:54 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 20:23:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b865eb88a8e8834ca0f5c6e9e55288bf43e5d92b
Cr-Commit-Position: refs/heads/master@{#334903}

Powered by Google App Engine
This is Rietveld 408576698