Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1190783007: Implemented getBufferSubData, fixed bindTransformFeedback conformance issue. (Closed)

Created:
5 years, 6 months ago by bajones
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, Rik, dglazkov+blink, dshwang, Justin Novosad
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implemented getBufferSubData, fixed bindTransformFeedback conformance issue. BUG=295792 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M Source/core/html/canvas/WebGL2RenderingContextBase.cpp View 2 chunks +12 lines, -3 lines 0 comments Download
M public/platform/WebGraphicsContext3D.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bajones
kbr@chromium.org: Please review changes in WebGL2RenderingContextBase. jochen@chromium.org: Please review changes in WebGraphicsContext3D.
5 years, 6 months ago (2015-06-17 18:10:44 UTC) #2
jochen (gone - plz use gerrit)
lgtm once kbr is happy
5 years, 6 months ago (2015-06-18 09:45:42 UTC) #3
Ken Russell (switch to Gerrit)
LGTM. Nice work.
5 years, 6 months ago (2015-06-18 18:36:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190783007/1
5 years, 6 months ago (2015-06-18 18:38:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67287)
5 years, 6 months ago (2015-06-18 21:48:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190783007/1
5 years, 6 months ago (2015-06-18 21:51:52 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 01:37:27 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197416

Powered by Google App Engine
This is Rietveld 408576698