Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1190783006: Revert of Componentize HistoryURLProvider/ScoredHistoryMatch. (Closed)

Created:
5 years, 6 months ago by paulmeyer
Modified:
5 years, 6 months ago
Reviewers:
Peter Kasting, blundell
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@prepare_history_url_provider_for_c14n
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Componentize HistoryURLProvider/ScoredHistoryMatch. (patchset #3 id:60001 of https://codereview.chromium.org/1181113005/) Reason for revert: Speculative revert to fix the Windows unit_test failures. Original issue's description: > Componentize HistoryURLProvider/ScoredHistoryMatch. > > No changes are needed. > > BUG=371538 > > Committed: https://crrev.com/66c202106ea7ab3f3c078a5edfb4abf0d23cee94 > Cr-Commit-Position: refs/heads/master@{#334780} TBR=pkasting@chromium.org,blundell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371538 Committed: https://crrev.com/1b7219bbfc7470b6e48d008fa5e55e29e7f7898e Cr-Commit-Position: refs/heads/master@{#334868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2919 lines, -2924 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/autocomplete/history_url_provider.h View 1 chunk +344 lines, -0 lines 0 comments Download
A chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +1170 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/autocomplete/scored_history_match.h View 1 chunk +196 lines, -0 lines 0 comments Download
A chrome/browser/autocomplete/scored_history_match.cc View 1 chunk +699 lines, -0 lines 0 comments Download
A chrome/browser/autocomplete/scored_history_match_unittest.cc View 1 chunk +492 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/url_index_private_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 4 chunks +5 lines, -4 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/omnibox.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M components/omnibox/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
D components/omnibox/history_url_provider.h View 1 chunk +0 lines, -344 lines 0 comments Download
D components/omnibox/history_url_provider.cc View 1 chunk +0 lines, -1170 lines 0 comments Download
D components/omnibox/scored_history_match.h View 1 chunk +0 lines, -196 lines 0 comments Download
D components/omnibox/scored_history_match.cc View 1 chunk +0 lines, -699 lines 0 comments Download
D components/omnibox/scored_history_match_unittest.cc View 1 chunk +0 lines, -492 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
paulmeyer
Created Revert of Componentize HistoryURLProvider/ScoredHistoryMatch.
5 years, 6 months ago (2015-06-17 17:18:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190783006/1
5 years, 6 months ago (2015-06-17 17:18:29 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/autocomplete/in_memory_url_index.h: While running git apply --index -3 -p1; error: patch ...
5 years, 6 months ago (2015-06-17 17:19:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190783006/1
5 years, 6 months ago (2015-06-17 17:29:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 17:31:55 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1b7219bbfc7470b6e48d008fa5e55e29e7f7898e Cr-Commit-Position: refs/heads/master@{#334868}
5 years, 6 months ago (2015-06-17 17:32:50 UTC) #9
paulmeyer
5 years, 6 months ago (2015-06-17 17:56:55 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1191953004/ by paulmeyer@chromium.org.

The reason for reverting is: This revert broke other things. Reverting the
revert..

Powered by Google App Engine
This is Rietveld 408576698