Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2740)

Unified Diff: ash/display/display_error_observer_chromeos.cc

Issue 1190783003: Move "Dear Monitor..." error text from the notification title field to the message field to prevent… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/display_error_observer_chromeos.cc
diff --git a/ash/display/display_error_observer_chromeos.cc b/ash/display/display_error_observer_chromeos.cc
index 91e07db26008460c77bf17ccebe8a8d8c5b18fe5..19947e4af9876bdd7b40f09cc272944420abb243 100644
--- a/ash/display/display_error_observer_chromeos.cc
+++ b/ash/display/display_error_observer_chromeos.cc
@@ -43,17 +43,14 @@ void DisplayErrorObserver::OnDisplayModeChangeFailed(
ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
scoped_ptr<Notification> notification(new Notification(
- message_center::NOTIFICATION_TYPE_SIMPLE,
- kDisplayErrorNotificationId,
- l10n_util::GetStringUTF16(message_id),
+ message_center::NOTIFICATION_TYPE_SIMPLE, kDisplayErrorNotificationId,
Jun Mukai 2015/06/17 21:54:43 Please keep the original linebreak
Jun Mukai 2015/06/17 22:32:53 You miss this comment. Put a line break between NO
rfrappier 2015/06/18 15:39:53 Done.
base::string16(), // message
Jun Mukai 2015/06/17 21:54:43 Please update the comment. Now this is title, not
rfrappier 2015/06/18 15:39:53 Done.
+ l10n_util::GetStringUTF16(message_id),
bundle.GetImageNamed(IDR_AURA_NOTIFICATION_DISPLAY),
base::string16(), // display_source
- message_center::NotifierId(
- message_center::NotifierId::SYSTEM_COMPONENT,
- system_notifier::kNotifierDisplayError),
- message_center::RichNotificationData(),
- NULL));
+ message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,
+ system_notifier::kNotifierDisplayError),
+ message_center::RichNotificationData(), NULL));
message_center::MessageCenter::Get()->AddNotification(notification.Pass());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698