Move "Dear Monitor..." error text from the notification title field to the message field to prevent…

Move "Dear Monitor..." error text from the notification title field to the message field to prevent text cut-off.

BUG=497003
R=oshima@chromium.org

Committed: https://crrev.com/6b230c9e67c013402893857c8f3555961fb53609
Cr-Commit-Position: refs/heads/master@{#335526}

[rfrappier, 2015-06-17 17:12:46]

Ready for review

[oshima, 2015-06-17 21:52:09]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2015-06-17 21:52:09]

mukai@, can you review this?

[Jun Mukai, 2015-06-17 21:54:43]

https://codereview.chromium.org/1190783003/diff/1/ash/display/display_error_o...
File ash/display/display_error_observer_chromeos.cc (right):

https://codereview.chromium.org/1190783003/diff/1/ash/display/display_error_o...
ash/display/display_error_observer_chromeos.cc:46:
message_center::NOTIFICATION_TYPE_SIMPLE, kDisplayErrorNotificationId,
Please keep the original linebreak

https://codereview.chromium.org/1190783003/diff/1/ash/display/display_error_o...
ash/display/display_error_observer_chromeos.cc:47: base::string16(),  // message
Please update the comment. Now this is title, not message.

[rfrappier, 2015-06-17 22:12:43]

Ready for review

[Jun Mukai, 2015-06-17 22:32:54]

Please reply on each of my comments separately.  That is how our code review
goes.
If you just did the thing I said, simply click "Done" link.

https://codereview.chromium.org/1190783003/diff/1/ash/display/display_error_o...
File ash/display/display_error_observer_chromeos.cc (right):

https://codereview.chromium.org/1190783003/diff/1/ash/display/display_error_o...
ash/display/display_error_observer_chromeos.cc:46:
message_center::NOTIFICATION_TYPE_SIMPLE, kDisplayErrorNotificationId,
On 2015/06/17 21:54:43, Jun Mukai wrote:
> Please keep the original linebreak

You miss this comment. Put a line break between NOTIFICATION_TYPE_SIMPLE and
kDisplayErrorNotificationId as the original comment has.

[rfrappier, 2015-06-18 15:29:52]

Patchset #3 (id:40001) has been deleted

[rfrappier, 2015-06-18 15:37:23]

Patchset #4 (id:80001) has been deleted

[rfrappier, 2015-06-18 15:37:36]

Patchset #3 (id:60001) has been deleted

[rfrappier, 2015-06-18 15:39:53]

Ready for review. 

I found out that running "git cl format ash" moves "kDisplayErrorNotificationId"
to the previous line as well as adds 23 spaces in the beginning of line 53.

https://codereview.chromium.org/1190783003/diff/1/ash/display/display_error_o...
File ash/display/display_error_observer_chromeos.cc (right):

https://codereview.chromium.org/1190783003/diff/1/ash/display/display_error_o...
ash/display/display_error_observer_chromeos.cc:46:
message_center::NOTIFICATION_TYPE_SIMPLE, kDisplayErrorNotificationId,
On 2015/06/17 21:54:43, Jun Mukai wrote:
> Please keep the original linebreak

Done.

https://codereview.chromium.org/1190783003/diff/1/ash/display/display_error_o...
ash/display/display_error_observer_chromeos.cc:47: base::string16(),  // message
On 2015/06/17 21:54:43, Jun Mukai wrote:
> Please update the comment. Now this is title, not message.

Done.

[Jun Mukai, 2015-06-18 16:03:17]

lgtm

If that's what git-cl format does, I'm okay with that. Either is fine.

[rfrappier, 2015-06-19 21:47:55]

The CQ bit was checked by rfrappier@google.com

[commit-bot: I haz the power, 2015-06-19 21:49:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190783003/100001

[commit-bot: I haz the power, 2015-06-19 22:32:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 22:32:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rfrappier, 2015-06-22 17:12:22]

The CQ bit was checked by rfrappier@google.com

[rfrappier, 2015-06-22 17:12:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mukai@chromium.org
Link to the patchset: https://codereview.chromium.org/1190783003/#ps120001
(title: "Move "Dear Monitor..." error text from the notification title field to
the message field to prevent…")

[commit-bot: I haz the power, 2015-06-22 17:12:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190783003/120001

[oshima, 2015-06-22 17:13:48]

lgtm

[Jun Mukai, 2015-06-22 17:18:45]

The CQ bit was unchecked by mukai@chromium.org

[Jun Mukai, 2015-06-22 17:18:50]

https://codereview.chromium.org/1190783003/diff/120001/ash/display/display_er...
File ash/display/display_error_observer_chromeos.h (right):

https://codereview.chromium.org/1190783003/diff/120001/ash/display/display_er...
ash/display/display_error_observer_chromeos.h:31: base::string16
GetTitleOfDisplayErrorNotificationForTest();
Please remove this method. It's not necessary anymore.

[rfrappier, 2015-06-22 17:27:38]

Patchset #5 (id:140001) has been deleted

[rfrappier, 2015-06-22 17:29:40]

The CQ bit was checked by rfrappier@google.com

[rfrappier, 2015-06-22 17:29:40]

The patchset sent to the CQ was uploaded after l-g-t-m from mukai@chromium.org,
oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1190783003/#ps160001
(title: "Move "Dear Monitor..." error text from the notification title field to
the message field to prevent…")

[commit-bot: I haz the power, 2015-06-22 17:30:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190783003/160001

[commit-bot: I haz the power, 2015-06-22 18:15:21]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2015-06-22 18:16:24]

Patchset 5 (id:??) landed as
https://crrev.com/6b230c9e67c013402893857c8f3555961fb53609
Cr-Commit-Position: refs/heads/master@{#335526}