Make AutocompleteErrorEventInit.reason be of type AutocompleteErrorReason (not DOMString)

Make AutocompleteErrorEventInit.reason be of type AutocompleteErrorReason (not DOMString)

BUG=498495
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197173

[shiva.jm, 2015-06-16 06:14:46]

Patchset #1 (id:1) has been deleted

[shiva.jm, 2015-06-16 06:18:43]

shiva.jm@samsung.com changed reviewers:
+ arv@chromium.org, habib.virji@samsung.com, pfeldman@chromium.org

[shiva.jm, 2015-06-16 06:23:11]

shiva.jm@samsung.com changed reviewers:
+ bashi@chromium.org, dstockwell@chromium.org, philipj@opera.com

[shiva.jm, 2015-06-16 06:23:11]

pls have a look.

[bashi, 2015-06-16 06:27:07]

non-owner LGTM

[shiva.jm, 2015-06-16 06:57:29]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-16 06:57:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190723002/20001

[philipj_slow, 2015-06-16 07:35:48]

Great, thanks! I just have a small nit about the test.

https://codereview.chromium.org/1190723002/diff/20001/LayoutTests/fast/events...
File
LayoutTests/fast/events/constructors/autocomplete-error-event-constructor.html
(right):

https://codereview.chromium.org/1190723002/diff/20001/LayoutTests/fast/events...
LayoutTests/fast/events/constructors/autocomplete-error-event-constructor.html:34:
shouldThrow("new AutocompleteErrorEvent('eventType', { reason: 'doremi'
}).reason");
Please remove the trailing ".reason" as it is the constructor that throws, we'll
never reach the point of trying to access reason. Also make a new section "//
Invalid reason throws exception" or similar, as "reason is passed" is
inaccurate.

[commit-bot: I haz the power, 2015-06-16 08:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 08:17:58]

Dry run: This issue passed the CQ dry run.

[shiva.jm, 2015-06-16 09:04:47]

Updated the review comments. pls have a look.

https://codereview.chromium.org/1190723002/diff/20001/LayoutTests/fast/events...
File
LayoutTests/fast/events/constructors/autocomplete-error-event-constructor.html
(right):

https://codereview.chromium.org/1190723002/diff/20001/LayoutTests/fast/events...
LayoutTests/fast/events/constructors/autocomplete-error-event-constructor.html:34:
shouldThrow("new AutocompleteErrorEvent('eventType', { reason: 'doremi'
}).reason");
On 2015/06/16 07:35:48, philipj wrote:
> Please remove the trailing ".reason" as it is the constructor that throws,
we'll
> never reach the point of trying to access reason. Also make a new section "//
> Invalid reason throws exception" or similar, as "reason is passed" is
> inaccurate.

Done.

[shiva.jm, 2015-06-16 09:05:00]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[shiva.jm, 2015-06-16 09:05:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/1190723002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-06-16 09:05:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190723002/40001

[commit-bot: I haz the power, 2015-06-16 10:27:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 10:27:01]

Dry run: This issue passed the CQ dry run.

[philipj_slow, 2015-06-16 15:01:30]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-06-16 15:01:31]

lgtm

[commit-bot: I haz the power, 2015-06-16 15:02:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190723002/40001

[commit-bot: I haz the power, 2015-06-16 15:06:12]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197173