Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(68)

Issue 1190693004: bindings: Re-enable cross-origin-objects.html test. (Closed)

Created:
4 years, 10 months ago by Yuki
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Re-enable cross-origin-objects.html test. I think http://crrev.com/1189983002 fixed the flakiness of the test, which was disabled at http://crrev.com/1180213004 . Re-enable the test. BUG=501284 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197328

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Yuki
Could you review this CL?
4 years, 10 months ago (2015-06-18 03:35:03 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-18 04:02:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190693004/20001
4 years, 10 months ago (2015-06-18 04:05:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59412)
4 years, 10 months ago (2015-06-18 04:35:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190693004/40001
4 years, 10 months ago (2015-06-18 06:25:37 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 07:53:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197328

Powered by Google App Engine
This is Rietveld 408576698