Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: LayoutTests/fast/forms/form-collection-radio-node-list.html

Issue 119063002: Have HTMLFormElement's named getter return a RadioNodeList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update expected output for inspector/console/console-format-collections Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/form-collection-radio-node-list.html
diff --git a/LayoutTests/fast/forms/form-collection-radio-node-list.html b/LayoutTests/fast/forms/form-collection-radio-node-list.html
index 39b2a998ef11675a469ffd35694166adbc6561cf..2ccc284a709a099019ff8d0e4410f28278ba11c9 100644
--- a/LayoutTests/fast/forms/form-collection-radio-node-list.html
+++ b/LayoutTests/fast/forms/form-collection-radio-node-list.html
@@ -117,10 +117,31 @@ shouldBe('radioNodeList2.length', '3');
shouldBe('radioNodeList2[0].type', "'text'");
shouldBe('radioNodeList2[1].type', "'email'");
+var resetElement = radioNodeList2[2];
shouldBe('radioNodeList2[2].type', "'reset'");
radioNodeList2[2].id = "idChanged";
debug("After changing the id");
shouldBe('radioNodeList2.length', '2');
+// reset for use below.
+resetElement.id = "commoninput";
esprehn 2013/12/19 11:02:48 I'd rather you just added a new test instead of ha
sof 2013/12/19 12:15:05 ok, i've reverted this extra test over the form's
+debug("After resetting the id");
+shouldBe('radioNodeList2.length', '3');
+debug("");
+
+debug("Check RadioNodeList created from a form element");
+var radioNodeList3 = owner["commoninput"];
+shouldBe('radioNodeList3.length', '3');
+
+shouldBe('radioNodeList3[0].type', "'text'");
+shouldBe('radioNodeList3[1].type', "'email'");
+var resetElement = radioNodeList3[2];
+shouldBe('radioNodeList3[2].type', "'reset'");
+radioNodeList3[2].id = "idChanged";
+debug("After changing the id");
+shouldBe('radioNodeList3.length', '2');
+resetElement.id = "commoninput";
+debug("After resetting the id");
+shouldBe('radioNodeList3.length', '3');
debug("");
debug("Check that object element also reflects in RadioNodeList.");

Powered by Google App Engine
This is Rietveld 408576698