chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 11906008: Make Mac menu code obey incognito availability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 11906008: Make Mac menu code obey incognito availability. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adjust comment Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

index 9f3c8fde2fafc9bcec872a2b2e6147d251d1f790..67c41deb42b6fa83785a32eb1bd1812da1dad5df 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

@@ -49,7 +49,7 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

return [NSString stringWithFormat:@"%@\n%@", title, url];

}

-- (id)initWithBridge:(BookmarkMenuBridge *)bridge

+- (id)initWithBridge:(BookmarkMenuBridge*)bridge

andMenu:(NSMenu*)menu {

if ((self = [super init])) {

bridge_ = bridge;

@@ -72,7 +72,7 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

- (BOOL)validateMenuItem:(NSMenuItem*)menuItem {

AppController* controller = [NSApp delegate];

- return [controller keyWindowIsNotModal];

+ return ![controller keyWindowIsModal];

}

// NSMenu delegate method: called just before menu is displayed.

« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm » ('j') | no next file with comments »