Make Mac menu code obey incognito availability.

chrome/browser/ui/browser_command_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_
 #define CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_
 
 #include "base/prefs/public/pref_change_registrar.h"
 #include "chrome/browser/api/sync/profile_sync_service_observer.h"
 #include "chrome/browser/command_updater.h"
@@ skipping 48 matching lines @@
   int GetLastBlockedCommand(WindowOpenDisposition* disposition);
 
   // Notifies the controller that state has changed in one of the following
   // areas and it should update command states.
   void TabStateChanged();
   void ContentRestrictionsChanged();
   void FullscreenStateChanged();
   void PrintingStateChanged();
   void LoadingStateChanged(bool is_loading, bool force);
 
+  // Shared state updating: these functions are static and public to share with
+  // outside code.
+
+  // Updates the open-file state (Mac-only).
+  static void UpdateOpenFileState(CommandUpdater* command_updater);
+
+  // Update commands whose state depends on incognito mode availability and that
+  // only depend on the profile.

[Robert Sesek, 2013/01/16 18:24:50]

nit: dependS?

[Avi (use Gerrit), 2013/01/16 19:04:37]

The commands depend on the profile. Awkward constructions ftw.

+  static void UpdateSharedCommandsForIncognitoAvailability(
+      CommandUpdater* command_updater,
+      Profile* profile);
+
  private:
   enum FullScreenMode {
     // Not in fullscreen mode.
     FULLSCREEN_DISABLED,
 
     // Fullscreen mode, occupying the whole screen.
     FULLSCREEN_NORMAL,
 
     // Fullscreen mode for metro snap, occupying the full height and 20% of
     // the screen width.
@@ skipping 77 matching lines @@
   // Update commands whose state depends on whether multiple profiles are
   // allowed.
   void UpdateCommandsForMultipleProfiles();
 
   // Updates the printing command state.
   void UpdatePrintingState();
 
   // Updates the save-page-as command state.
   void UpdateSaveAsState();
 
-  // Updates the open-file state (Mac Only).
-  void UpdateOpenFileState();
-
   // Ask the Reload/Stop button to change its icon, and update the Stop command
   // state.  |is_loading| is true if the current WebContents is loading.
   // |force| is true if the button should change its icon immediately.
   void UpdateReloadStopState(bool is_loading, bool force);
 
   // Updates commands for find.
   void UpdateCommandsForFind();
 
   // Add/remove observers for interstitial attachment/detachment from
   // |contents|.
@@ skipping 22 matching lines @@
   content::NotificationRegistrar registrar_;
   PrefChangeRegistrar profile_pref_registrar_;
   PrefChangeRegistrar local_pref_registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserCommandController);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_