Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 11906006: Roll grit 100:101 (Closed)

Created:
7 years, 11 months ago by newt (away)
Modified:
7 years, 11 months ago
Reviewers:
Sergey Ulanov, Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Roll grit 100:101 r101: Make grit build's -f flag relative to cwd. This also updates remoting.gyp to the new usage of -f. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176978

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
newt (away)
PTAL, thanks
7 years, 11 months ago (2013-01-15 19:13:00 UTC) #1
Sergey Ulanov
lgtm
7 years, 11 months ago (2013-01-15 19:15:27 UTC) #2
Jói
LGTM To confirm: You don't need to update the default value for -f since that ...
7 years, 11 months ago (2013-01-15 19:18:06 UTC) #3
newt (away)
On 2013/01/15 19:18:06, Jói wrote: > LGTM > > To confirm: You don't need to ...
7 years, 11 months ago (2013-01-15 19:21:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11906006/2001
7 years, 11 months ago (2013-01-15 19:45:37 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-15 21:47:27 UTC) #6
Message was sent while issue was closed.
Change committed as 176978

Powered by Google App Engine
This is Rietveld 408576698