OLD | NEW |
1 /* | 1 /* |
2 * Copyright (C) 2009 Google Inc. All rights reserved. | 2 * Copyright (C) 2009 Google Inc. All rights reserved. |
3 * | 3 * |
4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are |
6 * met: | 6 * met: |
7 * | 7 * |
8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright |
9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above |
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
375 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8MajorGC"); | 375 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8MajorGC"); |
376 } else { | 376 } else { |
377 MajorGCWrapperVisitor visitor(isolate, constructRetainedObjectInfos); | 377 MajorGCWrapperVisitor visitor(isolate, constructRetainedObjectInfos); |
378 v8::V8::VisitHandlesWithClassIds(isolate, &visitor); | 378 v8::V8::VisitHandlesWithClassIds(isolate, &visitor); |
379 visitor.notifyFinished(); | 379 visitor.notifyFinished(); |
380 } | 380 } |
381 } | 381 } |
382 | 382 |
383 void V8GCController::gcEpilogue(v8::GCType type, v8::GCCallbackFlags flags) | 383 void V8GCController::gcEpilogue(v8::GCType type, v8::GCCallbackFlags flags) |
384 { | 384 { |
| 385 // v8::kGCCallbackFlagForced forces a Blink heap garbage collection |
| 386 // when a garbage collection was forced from V8. This is either used |
| 387 // for tests that force GCs from JavaScript to verify that objects die |
| 388 // when expected, or when handling memory pressure notifications. |
| 389 bool forceGC = flags & v8::kGCCallbackFlagForced; |
| 390 |
385 // FIXME: It would be nice if the GC callbacks passed the Isolate directly..
.. | 391 // FIXME: It would be nice if the GC callbacks passed the Isolate directly..
.. |
386 v8::Isolate* isolate = v8::Isolate::GetCurrent(); | 392 v8::Isolate* isolate = v8::Isolate::GetCurrent(); |
387 if (type == v8::kGCTypeScavenge) { | 393 if (type == v8::kGCTypeScavenge) { |
388 minorGCEpilogue(isolate); | 394 minorGCEpilogue(isolate); |
389 } else if (type == v8::kGCTypeMarkSweepCompact) { | 395 } else if (type == v8::kGCTypeMarkSweepCompact) { |
390 majorGCEpilogue(isolate); | 396 majorGCEpilogue(isolate); |
391 ThreadState::current()->didV8GC(); | 397 if (!forceGC) |
| 398 ThreadState::current()->didV8MajorGC(); |
392 } | 399 } |
393 | 400 |
394 // Forces a Blink heap garbage collection when a garbage collection | 401 if (forceGC) { |
395 // was forced from V8. This is used for tests that force GCs from | |
396 // JavaScript to verify that objects die when expected. | |
397 if (flags & v8::kGCCallbackFlagForced) { | |
398 // This single GC is not enough for two reasons: | 402 // This single GC is not enough for two reasons: |
399 // (1) The GC is not precise because the GC scans on-stack pointers co
nservatively. | 403 // (1) The GC is not precise because the GC scans on-stack pointers co
nservatively. |
400 // (2) One GC is not enough to break a chain of persistent handles. It
's possible that | 404 // (2) One GC is not enough to break a chain of persistent handles. It
's possible that |
401 // some heap allocated objects own objects that contain persistent
handles | 405 // some heap allocated objects own objects that contain persistent
handles |
402 // pointing to other heap allocated objects. To break the chain, w
e need multiple GCs. | 406 // pointing to other heap allocated objects. To break the chain, w
e need multiple GCs. |
403 // | 407 // |
404 // Regarding (1), we force a precise GC at the end of the current event
loop. So if you want | 408 // Regarding (1), we force a precise GC at the end of the current event
loop. So if you want |
405 // to collect all garbage, you need to wait until the next event loop. | 409 // to collect all garbage, you need to wait until the next event loop. |
406 // Regarding (2), it would be OK in practice to trigger only one GC per
gcEpilogue, because | 410 // Regarding (2), it would be OK in practice to trigger only one GC per
gcEpilogue, because |
407 // GCController.collectAll() forces 7 V8's GC. | 411 // GCController.collectAll() forces 7 V8's GC. |
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
497 Visitor* m_visitor; | 501 Visitor* m_visitor; |
498 }; | 502 }; |
499 | 503 |
500 void V8GCController::traceDOMWrappers(v8::Isolate* isolate, Visitor* visitor) | 504 void V8GCController::traceDOMWrappers(v8::Isolate* isolate, Visitor* visitor) |
501 { | 505 { |
502 DOMWrapperTracer tracer(visitor); | 506 DOMWrapperTracer tracer(visitor); |
503 v8::V8::VisitHandlesWithClassIds(isolate, &tracer); | 507 v8::V8::VisitHandlesWithClassIds(isolate, &tracer); |
504 } | 508 } |
505 | 509 |
506 } // namespace blink | 510 } // namespace blink |
OLD | NEW |