move processContentSecurityPolicy to WorkerScriptLoader

move processContentSecurityPolicy to WorkerScriptLoader

- Move ContentSecurityPolicy related code from WorkerScriptLoaderClient
  to WorkerScriptLoader. This is preparation for using callbacks instead of
  WorkerScriptLoaderClient and integrating WebEmbeddedWorkerImpl::Loader
  and WebSharedWorkerImpl::Loader to WorkerScriptLoader.

- Call processContentSecurityPolicy() not from each inheritance but
  from WorkerScriptLoader so that behaviors could be consistent easily.

BUG=500856
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197334

[Takashi Toyoshima, 2015-06-16 08:17:40]

Patchset #2 (id:20001) has been deleted

[Takashi Toyoshima, 2015-06-16 12:10:07]

toyoshim@chromium.org changed reviewers:
+ mkwst@chromium.org

[Takashi Toyoshima, 2015-06-16 12:10:08]

Hi Mike,
Can you take a look?

[Takashi Toyoshima, 2015-06-17 05:08:46]

toyoshim@chromium.org changed reviewers:
+ kinuko@chromium.org

[Takashi Toyoshima, 2015-06-17 05:09:27]

+kinuko for design around workers.

[Mike West, 2015-06-17 08:49:01]

The Content Security Policy bits LGTM. I'd like kinuko@ to sign off on the
design from a worker perspective before you land this, however.

+estark@, FYI, as she's been doing most of this CSP plumbing work. :)

[kinuko, 2015-06-17 13:47:55]

lgtm w/ one nit

https://codereview.chromium.org/1190493002/diff/100001/Source/core/workers/Wo...
File Source/core/workers/WorkerScriptLoader.h (right):

https://codereview.chromium.org/1190493002/diff/100001/Source/core/workers/Wo...
Source/core/workers/WorkerScriptLoader.h:78: void
setContentSecurityPolicy(PassRefPtr<ContentSecurityPolicy> policy) {
m_contentSecurityPolicy = policy; };
Is this method needed?  We seem to just create a new one in
processContentSecurityPolicy.

[Takashi Toyoshima, 2015-06-18 06:23:55]

https://codereview.chromium.org/1190493002/diff/100001/Source/core/workers/Wo...
File Source/core/workers/WorkerScriptLoader.h (right):

https://codereview.chromium.org/1190493002/diff/100001/Source/core/workers/Wo...
Source/core/workers/WorkerScriptLoader.h:78: void
setContentSecurityPolicy(PassRefPtr<ContentSecurityPolicy> policy) {
m_contentSecurityPolicy = policy; };
This is called from WebSharedWorkerImpl, and we do not set it in
processContentSecurityPolicy() if protocol is blob, file, and filesystem.

I think I can remove this, but it will need another review. So, I'll handle it
in a separate CL.

[Takashi Toyoshima, 2015-06-18 06:24:05]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2015-06-18 06:24:06]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1190493002/#ps120001
(title: "(rebase)")

[commit-bot: I haz the power, 2015-06-18 06:24:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190493002/120001

[kinuko, 2015-06-18 06:27:24]

On 2015/06/18 06:23:55, Takashi Toyoshima (chromium) wrote:
>
https://codereview.chromium.org/1190493002/diff/100001/Source/core/workers/Wo...
> File Source/core/workers/WorkerScriptLoader.h (right):
> 
>
https://codereview.chromium.org/1190493002/diff/100001/Source/core/workers/Wo...
> Source/core/workers/WorkerScriptLoader.h:78: void
> setContentSecurityPolicy(PassRefPtr<ContentSecurityPolicy> policy) {
> m_contentSecurityPolicy = policy; };
> This is called from WebSharedWorkerImpl, and we do not set it in
> processContentSecurityPolicy() if protocol is blob, file, and filesystem.
> 
> I think I can remove this, but it will need another review. So, I'll handle it
> in a separate CL.

Oh sorry, I misread. No, original patch is fine, no need to land them
separately.

[kinuko, 2015-06-18 06:27:34]

The CQ bit was unchecked by kinuko@chromium.org

[Takashi Toyoshima, 2015-06-18 09:43:25]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2015-06-18 09:43:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190493002/120001

[commit-bot: I haz the power, 2015-06-18 09:48:19]

Committed patchset #6 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197334