Replacing post-increment with pre-increment for consistency

content/renderer/media/webmediaplayer_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/webmediaplayer_util.h"
 
 #include <math.h>
 
 #include "media/base/media_keys.h"
 #include "third_party/WebKit/public/platform/WebMediaPlayerClient.h"
@@ skipping 13 matching lines @@
 
 base::TimeDelta ConvertSecondsToTimestamp(double seconds) {
   double microseconds = seconds * base::Time::kMicrosecondsPerSecond;
   return base::TimeDelta::FromMicroseconds(
       microseconds > 0 ? microseconds + 0.5 : ceil(microseconds - 0.5));
 }
 
 blink::WebTimeRanges ConvertToWebTimeRanges(
     const media::Ranges<base::TimeDelta>& ranges) {
   blink::WebTimeRanges result(ranges.size());
-  for (size_t i = 0; i < ranges.size(); i++) {
+  for (size_t i = 0; i < ranges.size(); ++i) {

[Ami GONE FROM CHROMIUM, 2013/12/19 21:21:01]

CL description says "to improve efficiency" but AFAICT Release builds of this
file before and after this change generate bit-exact results, because clang is
smart enough to make this change itself.  Do you have a toolchain where this is
not the case?

Using pre-increment instead of post-increment for PODs is rarely/never a
performance win, but it can be a readability win due to consistency with non-POD
pre-increment (where efficiency _can_ be an issue).

So, this change LGTM as long as you update the summary & description to
something more apt, like: "Replace post-increment with pre-increment for
consistency".

     result[i].start = ranges.start(i).InSecondsF();
     result[i].end = ranges.end(i).InSecondsF();
   }
   return result;
 }
 
 blink::WebMediaPlayer::NetworkState PipelineErrorToNetworkState(
     media::PipelineStatus error) {
   DCHECK_NE(error, media::PIPELINE_OK);
 
@@ skipping 26 matching lines @@
       return blink::WebMediaPlayer::NetworkStateDecodeError;
 
     case media::PIPELINE_OK:
     case media::PIPELINE_STATUS_MAX:
       NOTREACHED() << "Unexpected status! " << error;
   }
   return blink::WebMediaPlayer::NetworkStateFormatError;
 }
 
 }  // namespace content